|
 |
531551 |
From 28663e752e125da99f8636ea0227d168f1e0e6aa Mon Sep 17 00:00:00 2001
|
|
|
531551 |
From: Karel Zak <kzak@redhat.com>
|
|
|
531551 |
Date: Thu, 15 Oct 2015 11:53:44 +0200
|
|
|
531551 |
Subject: [PATCH 62/84] mount, umount, swapon, fsck, lsblk, findmnt: ignore
|
|
|
531551 |
malformed lines
|
|
|
531551 |
|
|
|
531551 |
The libmount provides way how to deal with parsing errors in fstab --
|
|
|
531551 |
on error callback function is executed and according to the return
|
|
|
531551 |
libmount manipulate with the malformed line, possible are three
|
|
|
531551 |
states:
|
|
|
531551 |
|
|
|
531551 |
1/ fatal error; all file ignored (callback rc < 0)
|
|
|
531551 |
2/ recoverable error; malformed line ignored (callback rc > 0)
|
|
|
531551 |
3/ ignore the error (callback rc == 0)
|
|
|
531551 |
|
|
|
531551 |
The 2/ is the default if no callback specified.
|
|
|
531551 |
|
|
|
531551 |
Unfortunately our utils uses 3/. The correct way is to use 2/.
|
|
|
531551 |
|
|
|
531551 |
Upstream: http://github.com/karelzak/util-linux/commit/1cd9d0d7463850ef6b16a78b8a55e56dbf9a8db1
|
|
|
531551 |
Upstream: http://github.com/karelzak/util-linux/commit/1bb02a2da9f1bf7d80b352d540b29371099ab570
|
|
|
531551 |
Addresses: http://bugzilla.redhat.com/show_bug.cgi?id=1271850
|
|
|
531551 |
Signed-off-by: Karel Zak <kzak@redhat.com>
|
|
|
531551 |
---
|
|
|
531551 |
disk-utils/fsck.c | 2 +-
|
|
|
531551 |
libmount/src/tab_parse.c | 2 +-
|
|
|
531551 |
misc-utils/findmnt.c | 2 +-
|
|
|
531551 |
misc-utils/lsblk.c | 11 +++++++++++
|
|
|
531551 |
sys-utils/mount.c | 2 +-
|
|
|
531551 |
sys-utils/swapon-common.c | 11 +++++++++++
|
|
|
531551 |
sys-utils/umount.c | 2 +-
|
|
|
531551 |
7 files changed, 27 insertions(+), 5 deletions(-)
|
|
|
531551 |
|
|
|
531551 |
diff --git a/disk-utils/fsck.c b/disk-utils/fsck.c
|
|
|
531551 |
index 6e3a2c0..3ef8e5b 100644
|
|
|
531551 |
--- a/disk-utils/fsck.c
|
|
|
531551 |
+++ b/disk-utils/fsck.c
|
|
|
531551 |
@@ -421,7 +421,7 @@ static int parser_errcb(struct libmnt_table *tb __attribute__ ((__unused__)),
|
|
|
531551 |
const char *filename, int line)
|
|
|
531551 |
{
|
|
|
531551 |
warnx(_("%s: parse error at line %d -- ignore"), filename, line);
|
|
|
531551 |
- return 0;
|
|
|
531551 |
+ return 1;
|
|
|
531551 |
}
|
|
|
531551 |
|
|
|
531551 |
/*
|
|
|
531551 |
diff --git a/libmount/src/tab_parse.c b/libmount/src/tab_parse.c
|
|
|
531551 |
index e930fd8..987e671 100644
|
|
|
531551 |
--- a/libmount/src/tab_parse.c
|
|
|
531551 |
+++ b/libmount/src/tab_parse.c
|
|
|
531551 |
@@ -540,7 +540,7 @@ int mnt_table_parse_stream(struct libmnt_table *tb, FILE *f, const char *filenam
|
|
|
531551 |
}
|
|
|
531551 |
if (rc) {
|
|
|
531551 |
mnt_free_fs(fs);
|
|
|
531551 |
- if (rc == 1)
|
|
|
531551 |
+ if (rc > 0)
|
|
|
531551 |
continue; /* recoverable error */
|
|
|
531551 |
if (feof(f))
|
|
|
531551 |
break;
|
|
|
531551 |
diff --git a/misc-utils/findmnt.c b/misc-utils/findmnt.c
|
|
|
531551 |
index 615ba08..f16da91 100644
|
|
|
531551 |
--- a/misc-utils/findmnt.c
|
|
|
531551 |
+++ b/misc-utils/findmnt.c
|
|
|
531551 |
@@ -752,7 +752,7 @@ static int parser_errcb(struct libmnt_table *tb __attribute__ ((__unused__)),
|
|
|
531551 |
const char *filename, int line)
|
|
|
531551 |
{
|
|
|
531551 |
warnx(_("%s: parse error at line %d"), filename, line);
|
|
|
531551 |
- return 0;
|
|
|
531551 |
+ return 1;
|
|
|
531551 |
}
|
|
|
531551 |
|
|
|
531551 |
static char **append_tabfile(char **files, int *nfiles, char *filename)
|
|
|
531551 |
diff --git a/misc-utils/lsblk.c b/misc-utils/lsblk.c
|
|
|
531551 |
index 9e12a90..cd28c1d 100644
|
|
|
531551 |
--- a/misc-utils/lsblk.c
|
|
|
531551 |
+++ b/misc-utils/lsblk.c
|
|
|
531551 |
@@ -337,6 +337,15 @@ static char *get_device_path(struct blkdev_cxt *cxt)
|
|
|
531551 |
return xstrdup(path);
|
|
|
531551 |
}
|
|
|
531551 |
|
|
|
531551 |
+static int table_parser_errcb(struct libmnt_table *tb __attribute__((__unused__)),
|
|
|
531551 |
+ const char *filename, int line)
|
|
|
531551 |
+{
|
|
|
531551 |
+ if (filename)
|
|
|
531551 |
+ warnx(_("%s: parse error: ignore entry at line %d."),
|
|
|
531551 |
+ filename, line);
|
|
|
531551 |
+ return 1;
|
|
|
531551 |
+}
|
|
|
531551 |
+
|
|
|
531551 |
static int is_active_swap(const char *filename)
|
|
|
531551 |
{
|
|
|
531551 |
if (!swaps) {
|
|
|
531551 |
@@ -346,6 +355,7 @@ static int is_active_swap(const char *filename)
|
|
|
531551 |
if (!mntcache)
|
|
|
531551 |
mntcache = mnt_new_cache();
|
|
|
531551 |
|
|
|
531551 |
+ mnt_table_set_parser_errcb(swaps, table_parser_errcb);
|
|
|
531551 |
mnt_table_set_cache(swaps, mntcache);
|
|
|
531551 |
mnt_table_parse_swaps(swaps, NULL);
|
|
|
531551 |
}
|
|
|
531551 |
@@ -368,6 +378,7 @@ static char *get_device_mountpoint(struct blkdev_cxt *cxt)
|
|
|
531551 |
if (!mntcache)
|
|
|
531551 |
mntcache = mnt_new_cache();
|
|
|
531551 |
|
|
|
531551 |
+ mnt_table_set_parser_errcb(mtab, table_parser_errcb);
|
|
|
531551 |
mnt_table_set_cache(mtab, mntcache);
|
|
|
531551 |
mnt_table_parse_mtab(mtab, NULL);
|
|
|
531551 |
}
|
|
|
531551 |
diff --git a/sys-utils/mount.c b/sys-utils/mount.c
|
|
|
531551 |
index 0998b01..f332070 100644
|
|
|
531551 |
--- a/sys-utils/mount.c
|
|
|
531551 |
+++ b/sys-utils/mount.c
|
|
|
531551 |
@@ -101,7 +101,7 @@ static int table_parser_errcb(struct libmnt_table *tb __attribute__((__unused__)
|
|
|
531551 |
if (filename)
|
|
|
531551 |
warnx(_("%s: parse error: ignore entry at line %d."),
|
|
|
531551 |
filename, line);
|
|
|
531551 |
- return 0;
|
|
|
531551 |
+ return 1;
|
|
|
531551 |
}
|
|
|
531551 |
|
|
|
531551 |
/*
|
|
|
531551 |
diff --git a/sys-utils/swapon-common.c b/sys-utils/swapon-common.c
|
|
|
531551 |
index 5c95ef3..5f14ddb 100644
|
|
|
531551 |
--- a/sys-utils/swapon-common.c
|
|
|
531551 |
+++ b/sys-utils/swapon-common.c
|
|
|
531551 |
@@ -11,12 +11,22 @@ static struct libmnt_table *swaps, *fstab;
|
|
|
531551 |
|
|
|
531551 |
struct libmnt_cache *mntcache;
|
|
|
531551 |
|
|
|
531551 |
+static int table_parser_errcb(struct libmnt_table *tb __attribute__((__unused__)),
|
|
|
531551 |
+ const char *filename, int line)
|
|
|
531551 |
+{
|
|
|
531551 |
+ if (filename)
|
|
|
531551 |
+ warnx(_("%s: parse error: ignore entry at line %d."),
|
|
|
531551 |
+ filename, line);
|
|
|
531551 |
+ return 1;
|
|
|
531551 |
+}
|
|
|
531551 |
+
|
|
|
531551 |
struct libmnt_table *get_fstab(void)
|
|
|
531551 |
{
|
|
|
531551 |
if (!fstab) {
|
|
|
531551 |
fstab = mnt_new_table();
|
|
|
531551 |
if (!fstab)
|
|
|
531551 |
return NULL;
|
|
|
531551 |
+ mnt_table_set_parser_errcb(fstab, table_parser_errcb);
|
|
|
531551 |
mnt_table_set_cache(fstab, mntcache);
|
|
|
531551 |
if (mnt_table_parse_fstab(fstab, NULL) != 0)
|
|
|
531551 |
return NULL;
|
|
|
531551 |
@@ -32,6 +42,7 @@ struct libmnt_table *get_swaps(void)
|
|
|
531551 |
if (!swaps)
|
|
|
531551 |
return NULL;
|
|
|
531551 |
mnt_table_set_cache(swaps, mntcache);
|
|
|
531551 |
+ mnt_table_set_parser_errcb(swaps, table_parser_errcb);
|
|
|
531551 |
if (mnt_table_parse_swaps(swaps, NULL) != 0)
|
|
|
531551 |
return NULL;
|
|
|
531551 |
}
|
|
|
531551 |
diff --git a/sys-utils/umount.c b/sys-utils/umount.c
|
|
|
531551 |
index 1bd275f..9c47744 100644
|
|
|
531551 |
--- a/sys-utils/umount.c
|
|
|
531551 |
+++ b/sys-utils/umount.c
|
|
|
531551 |
@@ -45,7 +45,7 @@ static int table_parser_errcb(struct libmnt_table *tb __attribute__((__unused__)
|
|
|
531551 |
if (filename)
|
|
|
531551 |
warnx(_("%s: parse error: ignore entry at line %d."),
|
|
|
531551 |
filename, line);
|
|
|
531551 |
- return 0;
|
|
|
531551 |
+ return 1;
|
|
|
531551 |
}
|
|
|
531551 |
|
|
|
531551 |
|
|
|
531551 |
--
|
|
|
531551 |
2.7.4
|
|
|
531551 |
|