From 63f3e6ee49e0a88bbd7915d81962c9046205c411 Mon Sep 17 00:00:00 2001 From: Yonit Halperin Date: Sun, 18 Mar 2012 09:42:39 +0200 Subject: [PATCH 423/434] monitor: fix client_migrate_info error handling Report QERR_MISSING_PARAMETER when port is missing. Otherwise QERR_UNDEFINED_ERROR will occur. rhbz #795652 Signed-off-by: Yonit Halperin Signed-off-by: Gerd Hoffmann --- monitor.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/monitor.c b/monitor.c index 3c23aa4..76739d7 100644 --- a/monitor.c +++ b/monitor.c @@ -1046,6 +1046,11 @@ static int client_migrate_info(Monitor *mon, const QDict *qdict, return -1; } + if (port == -1 && tls_port == -1) { + qerror_report(QERR_MISSING_PARAMETER, "port/tls-port"); + return -1; + } + ret = qemu_spice_migrate_info(hostname, port, tls_port, subject, cb, opaque); if (ret != 0) { -- 1.7.10