dcavalca / rpms / qemu

Forked from rpms/qemu a year ago
Clone

Blame qemu-0.9.1-block-rw-range-check.patch

Daniel P. Berrange 0778a1
diff -rup qemu-0.9.1.orig/block.c qemu-0.9.1.new/block.c
Daniel P. Berrange 0778a1
--- qemu-0.9.1.orig/block.c	2008-02-26 18:03:00.000000000 -0500
Daniel P. Berrange 0778a1
+++ qemu-0.9.1.new/block.c	2008-02-26 18:05:26.000000000 -0500
Daniel P. Berrange 0778a1
@@ -123,6 +123,60 @@ void path_combine(char *dest, int dest_s
Daniel P. Berrange b80713
     }
Daniel P. Berrange b80713
 }
Daniel P. Berrange b80713
 
Daniel P. Berrange 0778a1
+static int bdrv_rd_badreq_sectors(BlockDriverState *bs,
Daniel P. Berrange 0778a1
+                                  int64_t sector_num, int nb_sectors)
Daniel P. Berrange b80713
+{
Daniel P. Berrange b80713
+    return
Daniel P. Berrange 0778a1
+        nb_sectors < 0 ||
Daniel P. Berrange 0778a1
+        sector_num < 0 ||
Daniel P. Berrange 0778a1
+        nb_sectors > bs->total_sectors ||
Daniel P. Berrange 0778a1
+        sector_num > bs->total_sectors - nb_sectors;
Daniel P. Berrange b80713
+}
Daniel P. Berrange b80713
+
Daniel P. Berrange 0778a1
+static int bdrv_rd_badreq_bytes(BlockDriverState *bs,
Daniel P. Berrange 0778a1
+                                int64_t offset, int count)
Daniel P. Berrange b80713
+{
Daniel P. Berrange b80713
+    int64_t size = bs->total_sectors << SECTOR_BITS;
Daniel P. Berrange b80713
+    return
Daniel P. Berrange 0778a1
+        count < 0 ||
Daniel P. Berrange 0778a1
+        size < 0 ||
Daniel P. Berrange 0778a1
+        count > size ||
Daniel P. Berrange 0778a1
+        offset > size - count;
Daniel P. Berrange b80713
+}
Daniel P. Berrange 0778a1
+
Daniel P. Berrange 0778a1
+static int bdrv_wr_badreq_sectors(BlockDriverState *bs,
Daniel P. Berrange 0778a1
+                                  int64_t sector_num, int nb_sectors)
Daniel P. Berrange 0778a1
+{
Daniel P. Berrange 0778a1
+    if (sector_num < 0 ||
Daniel P. Berrange 0778a1
+        nb_sectors < 0)
Daniel P. Berrange 0778a1
+        return 1;
Daniel P. Berrange 0778a1
+
Daniel P. Berrange 0778a1
+    if (sector_num > bs->total_sectors - nb_sectors) {
Daniel P. Berrange 0778a1
+        if (bs->autogrow)
Daniel P. Berrange 0778a1
+            bs->total_sectors = sector_num + nb_sectors;
Daniel P. Berrange 0778a1
+        else
Daniel P. Berrange 0778a1
+            return 1;
Daniel P. Berrange 0778a1
+    }
Daniel P. Berrange 0778a1
+    return 0;
Daniel P. Berrange 0778a1
+}
Daniel P. Berrange 0778a1
+
Daniel P. Berrange 0778a1
+static int bdrv_wr_badreq_bytes(BlockDriverState *bs,
Daniel P. Berrange 0778a1
+                                int64_t offset, int count)
Daniel P. Berrange 0778a1
+{
Daniel P. Berrange 0778a1
+    int64_t size = bs->total_sectors << SECTOR_BITS;
Daniel P. Berrange 0778a1
+    if (count < 0 ||
Daniel P. Berrange 0778a1
+        offset < 0)
Daniel P. Berrange 0778a1
+        return 1;
Daniel P. Berrange 0778a1
+
Daniel P. Berrange 0778a1
+    if (offset > size - count) {
Daniel P. Berrange 0778a1
+        if (bs->autogrow)
Daniel P. Berrange 0778a1
+            bs->total_sectors = (offset + count + SECTOR_SIZE - 1) >> SECTOR_BITS;
Daniel P. Berrange 0778a1
+        else
Daniel P. Berrange 0778a1
+            return 1;
Daniel P. Berrange 0778a1
+    }
Daniel P. Berrange 0778a1
+    return 0;
Daniel P. Berrange 0778a1
+}
Daniel P. Berrange 0778a1
+
Daniel P. Berrange b80713
 
Daniel P. Berrange b80713
 static void bdrv_register(BlockDriver *bdrv)
Daniel P. Berrange b80713
 {
Daniel P. Berrange 0778a1
@@ -331,6 +385,10 @@ int bdrv_open2(BlockDriverState *bs, con
Daniel P. Berrange 0778a1
     bs->read_only = 0;
Daniel P. Berrange 0778a1
     bs->is_temporary = 0;
Daniel P. Berrange 0778a1
     bs->encrypted = 0;
Daniel P. Berrange 0778a1
+    bs->autogrow = 0;
Daniel P. Berrange 0778a1
+
Daniel P. Berrange 0778a1
+    if (flags & BDRV_O_AUTOGROW)
Daniel P. Berrange 0778a1
+        bs->autogrow = 1;
Daniel P. Berrange 0778a1
 
Daniel P. Berrange 0778a1
     if (flags & BDRV_O_SNAPSHOT) {
Daniel P. Berrange 0778a1
         BlockDriverState *bs1;
Daniel P. Berrange 0778a1
@@ -375,6 +433,7 @@ int bdrv_open2(BlockDriverState *bs, con
Daniel P. Berrange b80713
     }
Daniel P. Berrange b80713
     bs->drv = drv;
Daniel P. Berrange b80713
     bs->opaque = qemu_mallocz(drv->instance_size);
Daniel P. Berrange b80713
+    bs->total_sectors = 0; /* driver will set if it does not do getlength */
Daniel P. Berrange b80713
     if (bs->opaque == NULL && drv->instance_size > 0)
Daniel P. Berrange b80713
         return -1;
Daniel P. Berrange b80713
     /* Note: for compatibility, we open disk image files as RDWR, and
Daniel P. Berrange 0778a1
@@ -440,6 +499,7 @@ void bdrv_close(BlockDriverState *bs)
Daniel P. Berrange b80713
         bs->drv = NULL;
Daniel P. Berrange b80713
 
Daniel P. Berrange b80713
         /* call the change callback */
Daniel P. Berrange 0778a1
+        bs->total_sectors = 0;
Daniel P. Berrange b80713
         bs->media_changed = 1;
Daniel P. Berrange b80713
         if (bs->change_cb)
Daniel P. Berrange b80713
             bs->change_cb(bs->change_opaque);
Daniel P. Berrange 0778a1
@@ -505,6 +565,8 @@ int bdrv_read(BlockDriverState *bs, int6
Daniel P. Berrange b80713
     if (!drv)
Daniel P. Berrange b80713
         return -ENOMEDIUM;
Daniel P. Berrange b80713
 
Daniel P. Berrange 0778a1
+    if (bdrv_rd_badreq_sectors(bs, sector_num, nb_sectors))
Daniel P. Berrange 0778a1
+        return -EDOM;
Daniel P. Berrange b80713
     if (sector_num == 0 && bs->boot_sector_enabled && nb_sectors > 0) {
Daniel P. Berrange b80713
             memcpy(buf, bs->boot_sector_data, 512);
Daniel P. Berrange b80713
         sector_num++;
Daniel P. Berrange 0778a1
@@ -545,6 +607,8 @@ int bdrv_write(BlockDriverState *bs, int
Daniel P. Berrange b80713
         return -ENOMEDIUM;
Daniel P. Berrange b80713
     if (bs->read_only)
Daniel P. Berrange b80713
         return -EACCES;
Daniel P. Berrange 0778a1
+    if (bdrv_wr_badreq_sectors(bs, sector_num, nb_sectors))
Daniel P. Berrange 0778a1
+        return -EDOM;
Daniel P. Berrange b80713
     if (sector_num == 0 && bs->boot_sector_enabled && nb_sectors > 0) {
Daniel P. Berrange b80713
         memcpy(bs->boot_sector_data, buf, 512);
Daniel P. Berrange b80713
     }
Daniel P. Berrange 0778a1
@@ -670,6 +734,8 @@ int bdrv_pread(BlockDriverState *bs, int
Daniel P. Berrange b80713
         return -ENOMEDIUM;
Daniel P. Berrange b80713
     if (!drv->bdrv_pread)
Daniel P. Berrange b80713
         return bdrv_pread_em(bs, offset, buf1, count1);
Daniel P. Berrange 0778a1
+    if (bdrv_rd_badreq_bytes(bs, offset, count1))
Daniel P. Berrange 0778a1
+        return -EDOM;
Daniel P. Berrange b80713
     return drv->bdrv_pread(bs, offset, buf1, count1);
Daniel P. Berrange b80713
 }
Daniel P. Berrange b80713
 
Daniel P. Berrange 0778a1
@@ -685,6 +751,8 @@ int bdrv_pwrite(BlockDriverState *bs, in
Daniel P. Berrange b80713
         return -ENOMEDIUM;
Daniel P. Berrange b80713
     if (!drv->bdrv_pwrite)
Daniel P. Berrange b80713
         return bdrv_pwrite_em(bs, offset, buf1, count1);
Daniel P. Berrange 0778a1
+    if (bdrv_wr_badreq_bytes(bs, offset, count1))
Daniel P. Berrange 0778a1
+        return -EDOM;
Daniel P. Berrange b80713
     return drv->bdrv_pwrite(bs, offset, buf1, count1);
Daniel P. Berrange b80713
 }
Daniel P. Berrange b80713
 
Daniel P. Berrange 0778a1
@@ -951,6 +1019,8 @@ int bdrv_write_compressed(BlockDriverSta
Daniel P. Berrange b80713
         return -ENOMEDIUM;
Daniel P. Berrange b80713
     if (!drv->bdrv_write_compressed)
Daniel P. Berrange b80713
         return -ENOTSUP;
Daniel P. Berrange 0778a1
+    if (bdrv_wr_badreq_sectors(bs, sector_num, nb_sectors))
Daniel P. Berrange 0778a1
+        return -EDOM;
Daniel P. Berrange b80713
     return drv->bdrv_write_compressed(bs, sector_num, buf, nb_sectors);
Daniel P. Berrange b80713
 }
Daniel P. Berrange b80713
 
Daniel P. Berrange 0778a1
@@ -1097,6 +1167,8 @@ BlockDriverAIOCB *bdrv_aio_read(BlockDri
Daniel P. Berrange b80713
 
Daniel P. Berrange b80713
     if (!drv)
Daniel P. Berrange b80713
         return NULL;
Daniel P. Berrange 0778a1
+    if (bdrv_rd_badreq_sectors(bs, sector_num, nb_sectors))
Daniel P. Berrange 0778a1
+        return NULL;
Daniel P. Berrange b80713
 
Daniel P. Berrange b80713
     /* XXX: we assume that nb_sectors == 0 is suppored by the async read */
Daniel P. Berrange b80713
     if (sector_num == 0 && bs->boot_sector_enabled && nb_sectors > 0) {
Daniel P. Berrange 0778a1
@@ -1128,6 +1200,8 @@ BlockDriverAIOCB *bdrv_aio_write(BlockDr
Daniel P. Berrange b80713
         return NULL;
Daniel P. Berrange b80713
     if (bs->read_only)
Daniel P. Berrange b80713
         return NULL;
Daniel P. Berrange 0778a1
+    if (bdrv_wr_badreq_sectors(bs, sector_num, nb_sectors))
Daniel P. Berrange 0778a1
+        return NULL;
Daniel P. Berrange b80713
     if (sector_num == 0 && bs->boot_sector_enabled && nb_sectors > 0) {
Daniel P. Berrange b80713
         memcpy(bs->boot_sector_data, buf, 512);
Daniel P. Berrange b80713
     }
Daniel P. Berrange 0778a1
diff -rup qemu-0.9.1.orig/block.h qemu-0.9.1.new/block.h
Daniel P. Berrange 0778a1
--- qemu-0.9.1.orig/block.h	2008-01-06 14:38:42.000000000 -0500
Daniel P. Berrange 0778a1
+++ qemu-0.9.1.new/block.h	2008-02-26 17:41:47.000000000 -0500
Daniel P. Berrange 0778a1
@@ -45,6 +45,7 @@ typedef struct QEMUSnapshotInfo {
Daniel P. Berrange 0778a1
                                      it (default for
Daniel P. Berrange 0778a1
                                      bdrv_file_open()) */
Daniel P. Berrange 0778a1
 #define BDRV_O_DIRECT      0x0020
Daniel P. Berrange 0778a1
+#define BDRV_O_AUTOGROW    0x0040 /* Allow backing file to extend when writing past end of file */
Daniel P. Berrange 0778a1
 
Daniel P. Berrange 0778a1
 #ifndef QEMU_IMG
Daniel P. Berrange 0778a1
 void bdrv_info(void);
Daniel P. Berrange 0778a1
diff -rup qemu-0.9.1.orig/block_int.h qemu-0.9.1.new/block_int.h
Daniel P. Berrange 0778a1
--- qemu-0.9.1.orig/block_int.h	2008-01-06 14:38:42.000000000 -0500
Daniel P. Berrange 0778a1
+++ qemu-0.9.1.new/block_int.h	2008-02-26 17:41:47.000000000 -0500
Daniel P. Berrange 0778a1
@@ -97,6 +97,7 @@ struct BlockDriverState {
Daniel P. Berrange 0778a1
     int locked;    /* if true, the media cannot temporarily be ejected */
Daniel P. Berrange 0778a1
     int encrypted; /* if true, the media is encrypted */
Daniel P. Berrange 0778a1
     int sg;        /* if true, the device is a /dev/sg* */
Daniel P. Berrange 0778a1
+    int autogrow;  /* if true, the backing store can auto-extend to allocate new extents */
Daniel P. Berrange 0778a1
     /* event callback when inserting/removing */
Daniel P. Berrange 0778a1
     void (*change_cb)(void *opaque);
Daniel P. Berrange 0778a1
     void *change_opaque;
Daniel P. Berrange 0778a1
diff -rup qemu-0.9.1.orig/block-qcow2.c qemu-0.9.1.new/block-qcow2.c
Daniel P. Berrange 0778a1
--- qemu-0.9.1.orig/block-qcow2.c	2008-01-06 14:38:42.000000000 -0500
Daniel P. Berrange 0778a1
+++ qemu-0.9.1.new/block-qcow2.c	2008-02-26 18:01:06.000000000 -0500
Daniel P. Berrange 0778a1
@@ -191,7 +191,7 @@ static int qcow_open(BlockDriverState *b
Daniel P. Berrange 0778a1
     int len, i, shift, ret;
Daniel P. Berrange 0778a1
     QCowHeader header;
Daniel P. Berrange 0778a1
 
Daniel P. Berrange 0778a1
-    ret = bdrv_file_open(&s->hd, filename, flags);
Daniel P. Berrange 0778a1
+    ret = bdrv_file_open(&s->hd, filename, flags | BDRV_O_AUTOGROW);
Daniel P. Berrange 0778a1
     if (ret < 0)
Daniel P. Berrange 0778a1
         return ret;
Daniel P. Berrange 0778a1
     if (bdrv_pread(s->hd, 0, &header, sizeof(header)) != sizeof(header))
Daniel P. Berrange 0778a1
diff -rup qemu-0.9.1.orig/block-qcow.c qemu-0.9.1.new/block-qcow.c
Daniel P. Berrange 0778a1
--- qemu-0.9.1.orig/block-qcow.c	2008-01-06 14:38:41.000000000 -0500
Daniel P. Berrange 0778a1
+++ qemu-0.9.1.new/block-qcow.c	2008-02-26 18:00:53.000000000 -0500
Daniel P. Berrange 0778a1
@@ -95,7 +95,7 @@ static int qcow_open(BlockDriverState *b
Daniel P. Berrange 0778a1
     int len, i, shift, ret;
Daniel P. Berrange 0778a1
     QCowHeader header;
Daniel P. Berrange 0778a1
 
Daniel P. Berrange 0778a1
-    ret = bdrv_file_open(&s->hd, filename, flags);
Daniel P. Berrange 0778a1
+    ret = bdrv_file_open(&s->hd, filename, flags | BDRV_O_AUTOGROW);
Daniel P. Berrange 0778a1
     if (ret < 0)
Daniel P. Berrange 0778a1
         return ret;
Daniel P. Berrange 0778a1
     if (bdrv_pread(s->hd, 0, &header, sizeof(header)) != sizeof(header))
Daniel P. Berrange 0778a1
diff -rup qemu-0.9.1.orig/block-vmdk.c qemu-0.9.1.new/block-vmdk.c
Daniel P. Berrange 0778a1
--- qemu-0.9.1.orig/block-vmdk.c	2008-01-06 14:38:42.000000000 -0500
Daniel P. Berrange 0778a1
+++ qemu-0.9.1.new/block-vmdk.c	2008-02-26 18:02:17.000000000 -0500
Daniel P. Berrange 0778a1
@@ -376,7 +376,7 @@ static int vmdk_open(BlockDriverState *b
Daniel P. Berrange 0778a1
         flags = BDRV_O_RDONLY;
Daniel P. Berrange 0778a1
     fprintf(stderr, "(VMDK) image open: flags=0x%x filename=%s\n", flags, bs->filename);
Daniel P. Berrange 0778a1
 
Daniel P. Berrange 0778a1
-    ret = bdrv_file_open(&s->hd, filename, flags);
Daniel P. Berrange 0778a1
+    ret = bdrv_file_open(&s->hd, filename, flags | BDRV_O_AUTOGROW);
Daniel P. Berrange 0778a1
     if (ret < 0)
Daniel P. Berrange 0778a1
         return ret;
Daniel P. Berrange 0778a1
     if (bdrv_pread(s->hd, 0, &magic, sizeof(magic)) != sizeof(magic))