From eb94846280df3f1e2a91b6179fc05f9890b7e384 Mon Sep 17 00:00:00 2001

From: Gerd Hoffmann <kraxel@redhat.com>

Date: Fri, 10 Sep 2021 11:42:03 +0200

Subject: [PATCH 1/1] qxl: fix pre-save logic

MIME-Version: 1.0

Content-Type: text/plain; charset=UTF-8

Content-Transfer-Encoding: 8bit

Oops.  Logic is backwards.

Fixes: 39b8a183e2f3 ("qxl: remove assert in qxl_pre_save.")

Resolves: https://gitlab.com/qemu-project/qemu/-/issues/610

Resolves: https://bugzilla.redhat.com//show_bug.cgi?id=2002907

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>

Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>

Message-Id: <20210910094203.3582378-1-kraxel@redhat.com>

---

 hw/display/qxl.c | 2 +-

 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/display/qxl.c b/hw/display/qxl.c

index 43482d4364..29c80b4289 100644

--- a/hw/display/qxl.c

+++ b/hw/display/qxl.c

@@ -2252,7 +2252,7 @@ static int qxl_pre_save(void *opaque)

     } else {

         d->last_release_offset = (uint8_t *)d->last_release - ram_start;

     }

-    if (d->last_release_offset < d->vga.vram_size) {

+    if (d->last_release_offset >= d->vga.vram_size) {

         return 1;

     }

-- 

2.33.1