dcavalca / rpms / mdadm

Forked from rpms/mdadm 3 years ago
Clone

Blame SOURCES/Use-correct-syntax-for-passing-DEVLINKS-to-mdadm-fro.patch

2c1b57
From ceb5f8ef92c97d1f44c75a3b74f64aa12a3303ef Mon Sep 17 00:00:00 2001
2c1b57
From: NeilBrown <neilb@suse.com>
2c1b57
Date: Fri, 4 Aug 2017 15:30:02 +1000
2c1b57
Subject: [RHEL7.5 PATCH 165/169] Use correct syntax for passing DEVLINKS
2c1b57
 to mdadm from udev
2c1b57
2c1b57
 ${DEVLINKS}
2c1b57
is not valid udev syntax, and is passed through uninterpreted.
2c1b57
 $env{DEVLINKS}
2c1b57
or
2c1b57
  %e{DEVLINKS}
2c1b57
is correct.
2c1b57
2c1b57
Signed-off-by: NeilBrown <neilb@suse.com>
2c1b57
Signed-off-by: Jes Sorensen <jsorensen@fb.com>
2c1b57
---
2c1b57
 mdadm.8.in                  | 2 +-
2c1b57
 udev-md-raid-assembly.rules | 2 +-
2c1b57
 2 files changed, 2 insertions(+), 2 deletions(-)
2c1b57
2c1b57
diff --git a/mdadm.8.in b/mdadm.8.in
2c1b57
index 461c5de..e0747fb 100644
2c1b57
--- a/mdadm.8.in
2c1b57
+++ b/mdadm.8.in
2c1b57
@@ -2947,7 +2947,7 @@ This is the only context where the aliases are used.  They are
2c1b57
 usually provided by a
2c1b57
 .I udev
2c1b57
 rules mentioning
2c1b57
-.BR ${DEVLINKS} .
2c1b57
+.BR $env{DEVLINKS} .
2c1b57
 
2c1b57
 .IP +
2c1b57
 Does the device have a valid md superblock?  If a specific metadata
2c1b57
diff --git a/udev-md-raid-assembly.rules b/udev-md-raid-assembly.rules
2c1b57
index 8ca232a..9f055ed 100644
2c1b57
--- a/udev-md-raid-assembly.rules
2c1b57
+++ b/udev-md-raid-assembly.rules
2c1b57
@@ -30,7 +30,7 @@ LABEL="md_inc"
2c1b57
 
2c1b57
 # remember you can limit what gets auto/incrementally assembled by
2c1b57
 # mdadm.conf(5)'s 'AUTO' and selectively whitelist using 'ARRAY'
2c1b57
-ACTION=="add|change", IMPORT{program}="BINDIR/mdadm --incremental --export $devnode --offroot ${DEVLINKS}"
2c1b57
+ACTION=="add|change", IMPORT{program}="BINDIR/mdadm --incremental --export $devnode --offroot $env{DEVLINKS}"
2c1b57
 ACTION=="add|change", ENV{MD_STARTED}=="*unsafe*", ENV{MD_FOREIGN}=="no", ENV{SYSTEMD_WANTS}+="mdadm-last-resort@$env{MD_DEVICE}.timer"
2c1b57
 ACTION=="remove", ENV{ID_PATH}=="?*", RUN+="BINDIR/mdadm -If $name --path $env{ID_PATH}"
2c1b57
 ACTION=="remove", ENV{ID_PATH}!="?*", RUN+="BINDIR/mdadm -If $name"
2c1b57
-- 
2c1b57
2.7.4
2c1b57