dcavalca / rpms / mdadm

Forked from rpms/mdadm 3 years ago
Clone

Blame SOURCES/Detail-Stop-bothering1-about-md-drivers-older-than-0..patch

b7f731
From 901d5ee6da145033ac30fee68f4fec0e8af9eddc Mon Sep 17 00:00:00 2001
b7f731
From: Jes Sorensen <Jes.Sorensen@gmail.com>
b7f731
Date: Wed, 5 Apr 2017 15:26:53 -0400
b7f731
Subject: [RHEL7.5 PATCH 057/169] Detail: Stop bothering about md drivers
b7f731
 older than 0.90.00
b7f731
b7f731
Remove further handling of md driver version older than 0.90.00
b7f731
b7f731
Signed-off-by: Jes Sorensen <Jes.Sorensen@gmail.com>
b7f731
---
b7f731
 Detail.c | 27 +++++++--------------------
b7f731
 1 file changed, 7 insertions(+), 20 deletions(-)
b7f731
b7f731
diff --git a/Detail.c b/Detail.c
b7f731
index fa6d4c7..d4e6204 100644
b7f731
--- a/Detail.c
b7f731
+++ b/Detail.c
b7f731
@@ -54,7 +54,6 @@ int Detail(char *dev, struct context *c)
b7f731
 	 * Print out details for an md array
b7f731
 	 */
b7f731
 	int fd = open(dev, O_RDONLY);
b7f731
-	int vers;
b7f731
 	mdu_array_info_t array;
b7f731
 	mdu_disk_info_t *disks;
b7f731
 	int next;
b7f731
@@ -88,22 +87,14 @@ int Detail(char *dev, struct context *c)
b7f731
 			dev, strerror(errno));
b7f731
 		return rv;
b7f731
 	}
b7f731
-	vers = md_get_version(fd);
b7f731
-	if (vers < 0) {
b7f731
-		pr_err("%s does not appear to be an md device\n",
b7f731
-			dev);
b7f731
-		close(fd);
b7f731
-		return rv;
b7f731
-	}
b7f731
-	if (vers < 9000) {
b7f731
-		pr_err("cannot get detail for md device %s: driver version too old.\n",
b7f731
-			dev);
b7f731
+	sra = sysfs_read(fd, NULL, GET_VERSION|GET_DEVS);
b7f731
+	if (!sra) {
b7f731
+		pr_err("%s does not appear to be an md device\n", dev);
b7f731
 		close(fd);
b7f731
 		return rv;
b7f731
 	}
b7f731
-	sra = sysfs_read(fd, NULL, GET_VERSION|GET_DEVS);
b7f731
-	external = (sra != NULL && sra->array.major_version == -1
b7f731
-		    && sra->array.minor_version == -2);
b7f731
+	external = (sra != NULL && sra->array.major_version == -1 &&
b7f731
+		    sra->array.minor_version == -2);
b7f731
 	st = super_by_fd(fd, &subarray);
b7f731
 	if (md_get_array_info(fd, &array) == 0) {
b7f731
 		inactive = 0;
b7f731
@@ -378,9 +369,7 @@ int Detail(char *dev, struct context *c)
b7f731
 		}
b7f731
 
b7f731
 		/* Only try GET_BITMAP_FILE for 0.90.01 and later */
b7f731
-		if (vers >= 9001 &&
b7f731
-		    ioctl(fd, GET_BITMAP_FILE, &bmf) == 0 &&
b7f731
-		    bmf.pathname[0]) {
b7f731
+		if (ioctl(fd, GET_BITMAP_FILE, &bmf) == 0 && bmf.pathname[0]) {
b7f731
 			printf(" bitmap=%s", bmf.pathname);
b7f731
 		}
b7f731
 	} else {
b7f731
@@ -449,9 +438,7 @@ int Detail(char *dev, struct context *c)
b7f731
 			       array.not_persistent?"not ":"");
b7f731
 		printf("\n");
b7f731
 		/* Only try GET_BITMAP_FILE for 0.90.01 and later */
b7f731
-		if (vers >= 9001 &&
b7f731
-		    ioctl(fd, GET_BITMAP_FILE, &bmf) == 0 &&
b7f731
-		    bmf.pathname[0]) {
b7f731
+		if (ioctl(fd, GET_BITMAP_FILE, &bmf) == 0 && bmf.pathname[0]) {
b7f731
 			printf("     Intent Bitmap : %s\n", bmf.pathname);
b7f731
 			printf("\n");
b7f731
 		} else if (array.state & (1<
b7f731
-- 
b7f731
2.7.4
b7f731