|
 |
f5dd7b |
From 7bd59e7926c6921121087eb067befaa896c900a4 Mon Sep 17 00:00:00 2001
|
|
|
f5dd7b |
From: NeilBrown <neilb@suse.de>
|
|
|
f5dd7b |
Date: Wed, 18 Sep 2019 15:12:55 +1000
|
|
|
f5dd7b |
Subject: [RHEL7.8 PATCH V2 41/47] udev: allow for udev attribute reading bug.
|
|
|
f5dd7b |
|
|
|
f5dd7b |
There is a bug in udev (which will hopefully get fixed, but
|
|
|
f5dd7b |
we should allow for it anways).
|
|
|
f5dd7b |
When reading a sysfs attribute, it first reads the whole
|
|
|
f5dd7b |
value of the attribute, then reads again expecting to get
|
|
|
f5dd7b |
a read of 0 bytes, like you would with an ordinary file.
|
|
|
f5dd7b |
If the sysfs attribute changed between these two reads, it can
|
|
|
f5dd7b |
get a mixture of two values.
|
|
|
f5dd7b |
|
|
|
f5dd7b |
In particular, if it reads when 'array_state' is changing from
|
|
|
f5dd7b |
'clear' to 'inactive', it can find the value as "clear\nve".
|
|
|
f5dd7b |
|
|
|
f5dd7b |
This causes the test for "|clear|active" to fail, so systemd is allowed
|
|
|
f5dd7b |
to think that the array is ready - when it isn't.
|
|
|
f5dd7b |
|
|
|
f5dd7b |
So change the pattern to allow for this but adding a wildcard at
|
|
|
f5dd7b |
the end.
|
|
|
f5dd7b |
Also don't allow for an empty string - reading array_state will
|
|
|
f5dd7b |
never return an empty string - if it exists at all, it will be
|
|
|
f5dd7b |
non-empty.
|
|
|
f5dd7b |
|
|
|
f5dd7b |
Signed-off-by: NeilBrown <neilb@suse.de>
|
|
|
f5dd7b |
Signed-off-by: Jes Sorensen <jsorensen@fb.com>
|
|
|
f5dd7b |
---
|
|
|
f5dd7b |
udev-md-raid-arrays.rules | 2 +-
|
|
|
f5dd7b |
1 file changed, 1 insertion(+), 1 deletion(-)
|
|
|
f5dd7b |
|
|
|
f5dd7b |
diff --git a/udev-md-raid-arrays.rules b/udev-md-raid-arrays.rules
|
|
|
f5dd7b |
index d391665..c8fa8e8 100644
|
|
|
f5dd7b |
--- a/udev-md-raid-arrays.rules
|
|
|
f5dd7b |
+++ b/udev-md-raid-arrays.rules
|
|
|
f5dd7b |
@@ -14,7 +14,7 @@ ENV{DEVTYPE}=="partition", GOTO="md_ignore_state"
|
|
|
f5dd7b |
# never leave state 'inactive'
|
|
|
f5dd7b |
ATTR{md/metadata_version}=="external:[A-Za-z]*", ATTR{md/array_state}=="inactive", GOTO="md_ignore_state"
|
|
|
f5dd7b |
TEST!="md/array_state", ENV{SYSTEMD_READY}="0", GOTO="md_end"
|
|
|
f5dd7b |
-ATTR{md/array_state}=="|clear|inactive", ENV{SYSTEMD_READY}="0", GOTO="md_end"
|
|
|
f5dd7b |
+ATTR{md/array_state}=="clear*|inactive", ENV{SYSTEMD_READY}="0", GOTO="md_end"
|
|
|
f5dd7b |
LABEL="md_ignore_state"
|
|
|
f5dd7b |
|
|
|
f5dd7b |
IMPORT{program}="BINDIR/mdadm --detail --no-devices --export $devnode"
|
|
|
f5dd7b |
--
|
|
|
f5dd7b |
2.7.5
|
|
|
f5dd7b |
|