dcavalca / rpms / mdadm

Forked from rpms/mdadm 3 years ago
Clone

Blame SOURCES/0021-add-missing-units-to-examine.patch

c025cf
From 227aeaa872d4898273cf87a4253898823d556c43 Mon Sep 17 00:00:00 2001
c025cf
From: Corey Hickey <bugfood-c@fatooh.org>
c025cf
Date: Mon, 11 Feb 2019 17:42:27 -0800
c025cf
Subject: [RHEL7.7 PATCH 21/21] add missing units to --examine
c025cf
c025cf
Within the output of "mdadm --examine", there are three sizes reported
c025cf
on adjacent lines. For example:
c025cf
c025cf
$ sudo mdadm --examine /dev/md3
c025cf
[...]
c025cf
 Avail Dev Size : 17580545024 (8383.06 GiB 9001.24 GB)
c025cf
     Array Size : 17580417024 (16765.99 GiB 18002.35 GB)
c025cf
  Used Dev Size : 11720278016 (5588.66 GiB 6000.78 GB)
c025cf
[...]
c025cf
c025cf
This can be confusing, since the first and third line are in 512-byte
c025cf
sectors, and the second is in KiB.
c025cf
c025cf
Add units to avoid ambiguity.
c025cf
c025cf
(I don't particularly like the "KiB" notation, but it is at least
c025cf
unambiguous.)
c025cf
c025cf
Signed-off-by: Corey Hickey <bugfood-c@fatooh.org>
c025cf
Signed-off-by: Jes Sorensen <jsorensen@fb.com>
c025cf
---
c025cf
 super1.c | 6 +++---
c025cf
 1 file changed, 3 insertions(+), 3 deletions(-)
c025cf
c025cf
diff --git a/super1.c b/super1.c
c025cf
index 636a286..b85dc20 100644
c025cf
--- a/super1.c
c025cf
+++ b/super1.c
c025cf
@@ -360,7 +360,7 @@ static void examine_super1(struct supertype *st, char *homehost)
c025cf
 	printf("     Raid Level : %s\n", c?c:"-unknown-");
c025cf
 	printf("   Raid Devices : %d\n", __le32_to_cpu(sb->raid_disks));
c025cf
 	printf("\n");
c025cf
-	printf(" Avail Dev Size : %llu%s\n",
c025cf
+	printf(" Avail Dev Size : %llu sectors%s\n",
c025cf
 	       (unsigned long long)__le64_to_cpu(sb->data_size),
c025cf
 	       human_size(__le64_to_cpu(sb->data_size)<<9));
c025cf
 	if (__le32_to_cpu(sb->level) > 0) {
c025cf
@@ -378,11 +378,11 @@ static void examine_super1(struct supertype *st, char *homehost)
c025cf
 		if (ddsks) {
c025cf
 			long long asize = __le64_to_cpu(sb->size);
c025cf
 			asize = (asize << 9) * ddsks / ddsks_denom;
c025cf
-			printf("     Array Size : %llu%s\n",
c025cf
+			printf("     Array Size : %llu KiB%s\n",
c025cf
 			       asize >> 10,  human_size(asize));
c025cf
 		}
c025cf
 		if (sb->size != sb->data_size)
c025cf
-			printf("  Used Dev Size : %llu%s\n",
c025cf
+			printf("  Used Dev Size : %llu sectors%s\n",
c025cf
 			       (unsigned long long)__le64_to_cpu(sb->size),
c025cf
 			       human_size(__le64_to_cpu(sb->size)<<9));
c025cf
 	}
c025cf
-- 
c025cf
2.7.5
c025cf