dcavalca / rpms / mdadm

Forked from rpms/mdadm 3 years ago
Clone

Blame SOURCES/0014-super-intel-Avoid-gcc-8.1-complaining-about-truncati.patch

d922d5
From 40659392ff90fc9c2861ec18c34ed1bdb54f92ca Mon Sep 17 00:00:00 2001
d922d5
From: Jes Sorensen <jsorensen@fb.com>
d922d5
Date: Wed, 30 May 2018 11:56:37 -0400
d922d5
Subject: [RHEL7.5 PATCH 14/26] super-intel: Avoid gcc-8.1 complaining about
d922d5
 truncating snprintf()
d922d5
d922d5
We know the max size of the volume name, so no need to play the
d922d5
snprintf() game.
d922d5
d922d5
Signed-off-by: Jes Sorensen <jsorensen@fb.com>
d922d5
---
d922d5
 super-intel.c | 3 ++-
d922d5
 1 file changed, 2 insertions(+), 1 deletion(-)
d922d5
d922d5
diff --git a/super-intel.c b/super-intel.c
d922d5
index cc53f0f..520d292 100644
d922d5
--- a/super-intel.c
d922d5
+++ b/super-intel.c
d922d5
@@ -9881,6 +9881,7 @@ static void imsm_process_update(struct supertype *st,
d922d5
 		/* sanity check that we are not affecting the uuid of
d922d5
 		 * an active array
d922d5
 		 */
d922d5
+		memset(name, 0, sizeof(name));
d922d5
 		snprintf(name, MAX_RAID_SERIAL_LEN, "%s", (char *) u->name);
d922d5
 		name[MAX_RAID_SERIAL_LEN] = '\0';
d922d5
 		for (a = st->arrays; a; a = a->next)
d922d5
@@ -9892,7 +9893,7 @@ static void imsm_process_update(struct supertype *st,
d922d5
 			break;
d922d5
 		}
d922d5
 
d922d5
-		snprintf((char *) dev->volume, MAX_RAID_SERIAL_LEN, "%s", name);
d922d5
+		memcpy(dev->volume, name, MAX_RAID_SERIAL_LEN);
d922d5
 		super->updates_pending++;
d922d5
 		break;
d922d5
 	}
d922d5
-- 
d922d5
2.7.4
d922d5