|
 |
b1bcb2 |
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
|
b1bcb2 |
From: Peter Jones <pjones@redhat.com>
|
|
|
b1bcb2 |
Date: Mon, 15 Feb 2021 13:59:21 +0100
|
|
|
b1bcb2 |
Subject: [PATCH] util/mkimage: Use grub_host_to_target32() instead of
|
|
|
b1bcb2 |
grub_cpu_to_le32()
|
|
|
b1bcb2 |
|
|
|
b1bcb2 |
The latter doesn't take into account the target image endianness. There is
|
|
|
b1bcb2 |
a grub_cpu_to_le32_compile_time() but no compile time variant for function
|
|
|
b1bcb2 |
grub_host_to_target32(). So, let's keep using the other one for this case.
|
|
|
b1bcb2 |
|
|
|
b1bcb2 |
Signed-off-by: Peter Jones <pjones@redhat.com>
|
|
|
b1bcb2 |
Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
|
|
|
b1bcb2 |
Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
|
|
|
b1bcb2 |
---
|
|
|
b1bcb2 |
util/mkimage.c | 44 ++++++++++++++++++++++----------------------
|
|
|
b1bcb2 |
1 file changed, 22 insertions(+), 22 deletions(-)
|
|
|
b1bcb2 |
|
|
|
b1bcb2 |
diff --git a/util/mkimage.c b/util/mkimage.c
|
|
|
b1bcb2 |
index 55bfd1d8b9e..f4f84dbecd0 100644
|
|
|
b1bcb2 |
--- a/util/mkimage.c
|
|
|
b1bcb2 |
+++ b/util/mkimage.c
|
|
|
b1bcb2 |
@@ -1458,10 +1458,10 @@ grub_install_generate_image (const char *dir, const char *prefix,
|
|
|
b1bcb2 |
+ sizeof (struct grub_pe32_coff_header));
|
|
|
b1bcb2 |
o->magic = grub_host_to_target16 (GRUB_PE32_PE32_MAGIC);
|
|
|
b1bcb2 |
o->code_size = grub_host_to_target32 (exec_size);
|
|
|
b1bcb2 |
- o->data_size = grub_cpu_to_le32 (reloc_addr - exec_size
|
|
|
b1bcb2 |
+ o->data_size = grub_host_to_target32 (reloc_addr - exec_size
|
|
|
b1bcb2 |
- header_size);
|
|
|
b1bcb2 |
- o->entry_addr = grub_cpu_to_le32 (start_address);
|
|
|
b1bcb2 |
- o->code_base = grub_cpu_to_le32 (header_size);
|
|
|
b1bcb2 |
+ o->entry_addr = grub_host_to_target32 (start_address);
|
|
|
b1bcb2 |
+ o->code_base = grub_host_to_target32 (header_size);
|
|
|
b1bcb2 |
|
|
|
b1bcb2 |
o->data_base = grub_host_to_target32 (header_size + exec_size);
|
|
|
b1bcb2 |
|
|
|
b1bcb2 |
@@ -1495,10 +1495,10 @@ grub_install_generate_image (const char *dir, const char *prefix,
|
|
|
b1bcb2 |
+ sizeof (struct grub_pe32_coff_header));
|
|
|
b1bcb2 |
o->magic = grub_host_to_target16 (GRUB_PE32_PE64_MAGIC);
|
|
|
b1bcb2 |
o->code_size = grub_host_to_target32 (exec_size);
|
|
|
b1bcb2 |
- o->data_size = grub_cpu_to_le32 (reloc_addr - exec_size
|
|
|
b1bcb2 |
+ o->data_size = grub_host_to_target32 (reloc_addr - exec_size
|
|
|
b1bcb2 |
- header_size);
|
|
|
b1bcb2 |
- o->entry_addr = grub_cpu_to_le32 (start_address);
|
|
|
b1bcb2 |
- o->code_base = grub_cpu_to_le32 (header_size);
|
|
|
b1bcb2 |
+ o->entry_addr = grub_host_to_target32 (start_address);
|
|
|
b1bcb2 |
+ o->code_base = grub_host_to_target32 (header_size);
|
|
|
b1bcb2 |
o->image_base = 0;
|
|
|
b1bcb2 |
o->section_alignment = grub_host_to_target32 (image_target->section_align);
|
|
|
b1bcb2 |
o->file_alignment = grub_host_to_target32 (image_target->section_align);
|
|
|
b1bcb2 |
@@ -1522,10 +1522,10 @@ grub_install_generate_image (const char *dir, const char *prefix,
|
|
|
b1bcb2 |
/* The sections. */
|
|
|
b1bcb2 |
text_section = sections;
|
|
|
b1bcb2 |
strcpy (text_section->name, ".text");
|
|
|
b1bcb2 |
- text_section->virtual_size = grub_cpu_to_le32 (exec_size);
|
|
|
b1bcb2 |
- text_section->virtual_address = grub_cpu_to_le32 (header_size);
|
|
|
b1bcb2 |
- text_section->raw_data_size = grub_cpu_to_le32 (exec_size);
|
|
|
b1bcb2 |
- text_section->raw_data_offset = grub_cpu_to_le32 (header_size);
|
|
|
b1bcb2 |
+ text_section->virtual_size = grub_host_to_target32 (exec_size);
|
|
|
b1bcb2 |
+ text_section->virtual_address = grub_host_to_target32 (header_size);
|
|
|
b1bcb2 |
+ text_section->raw_data_size = grub_host_to_target32 (exec_size);
|
|
|
b1bcb2 |
+ text_section->raw_data_offset = grub_host_to_target32 (header_size);
|
|
|
b1bcb2 |
text_section->characteristics = grub_cpu_to_le32_compile_time (
|
|
|
b1bcb2 |
GRUB_PE32_SCN_CNT_CODE
|
|
|
b1bcb2 |
| GRUB_PE32_SCN_MEM_EXECUTE
|
|
|
b1bcb2 |
@@ -1533,10 +1533,10 @@ grub_install_generate_image (const char *dir, const char *prefix,
|
|
|
b1bcb2 |
|
|
|
b1bcb2 |
data_section = text_section + 1;
|
|
|
b1bcb2 |
strcpy (data_section->name, ".data");
|
|
|
b1bcb2 |
- data_section->virtual_size = grub_cpu_to_le32 (kernel_size - exec_size);
|
|
|
b1bcb2 |
- data_section->virtual_address = grub_cpu_to_le32 (header_size + exec_size);
|
|
|
b1bcb2 |
- data_section->raw_data_size = grub_cpu_to_le32 (kernel_size - exec_size);
|
|
|
b1bcb2 |
- data_section->raw_data_offset = grub_cpu_to_le32 (header_size + exec_size);
|
|
|
b1bcb2 |
+ data_section->virtual_size = grub_host_to_target32 (kernel_size - exec_size);
|
|
|
b1bcb2 |
+ data_section->virtual_address = grub_host_to_target32 (header_size + exec_size);
|
|
|
b1bcb2 |
+ data_section->raw_data_size = grub_host_to_target32 (kernel_size - exec_size);
|
|
|
b1bcb2 |
+ data_section->raw_data_offset = grub_host_to_target32 (header_size + exec_size);
|
|
|
b1bcb2 |
data_section->characteristics
|
|
|
b1bcb2 |
= grub_cpu_to_le32_compile_time (GRUB_PE32_SCN_CNT_INITIALIZED_DATA
|
|
|
b1bcb2 |
| GRUB_PE32_SCN_MEM_READ
|
|
|
b1bcb2 |
@@ -1544,10 +1544,10 @@ grub_install_generate_image (const char *dir, const char *prefix,
|
|
|
b1bcb2 |
|
|
|
b1bcb2 |
mods_section = data_section + 1;
|
|
|
b1bcb2 |
strcpy (mods_section->name, "mods");
|
|
|
b1bcb2 |
- mods_section->virtual_size = grub_cpu_to_le32 (reloc_addr - kernel_size - header_size);
|
|
|
b1bcb2 |
- mods_section->virtual_address = grub_cpu_to_le32 (header_size + kernel_size + bss_size);
|
|
|
b1bcb2 |
- mods_section->raw_data_size = grub_cpu_to_le32 (reloc_addr - kernel_size - header_size);
|
|
|
b1bcb2 |
- mods_section->raw_data_offset = grub_cpu_to_le32 (header_size + kernel_size);
|
|
|
b1bcb2 |
+ mods_section->virtual_size = grub_host_to_target32 (reloc_addr - kernel_size - header_size);
|
|
|
b1bcb2 |
+ mods_section->virtual_address = grub_host_to_target32 (header_size + kernel_size + bss_size);
|
|
|
b1bcb2 |
+ mods_section->raw_data_size = grub_host_to_target32 (reloc_addr - kernel_size - header_size);
|
|
|
b1bcb2 |
+ mods_section->raw_data_offset = grub_host_to_target32 (header_size + kernel_size);
|
|
|
b1bcb2 |
mods_section->characteristics
|
|
|
b1bcb2 |
= grub_cpu_to_le32_compile_time (GRUB_PE32_SCN_CNT_INITIALIZED_DATA
|
|
|
b1bcb2 |
| GRUB_PE32_SCN_MEM_READ
|
|
|
b1bcb2 |
@@ -1555,10 +1555,10 @@ grub_install_generate_image (const char *dir, const char *prefix,
|
|
|
b1bcb2 |
|
|
|
b1bcb2 |
reloc_section = mods_section + 1;
|
|
|
b1bcb2 |
strcpy (reloc_section->name, ".reloc");
|
|
|
b1bcb2 |
- reloc_section->virtual_size = grub_cpu_to_le32 (reloc_size);
|
|
|
b1bcb2 |
- reloc_section->virtual_address = grub_cpu_to_le32 (reloc_addr + bss_size);
|
|
|
b1bcb2 |
- reloc_section->raw_data_size = grub_cpu_to_le32 (reloc_size);
|
|
|
b1bcb2 |
- reloc_section->raw_data_offset = grub_cpu_to_le32 (reloc_addr);
|
|
|
b1bcb2 |
+ reloc_section->virtual_size = grub_host_to_target32 (reloc_size);
|
|
|
b1bcb2 |
+ reloc_section->virtual_address = grub_host_to_target32 (reloc_addr + bss_size);
|
|
|
b1bcb2 |
+ reloc_section->raw_data_size = grub_host_to_target32 (reloc_size);
|
|
|
b1bcb2 |
+ reloc_section->raw_data_offset = grub_host_to_target32 (reloc_addr);
|
|
|
b1bcb2 |
reloc_section->characteristics
|
|
|
b1bcb2 |
= grub_cpu_to_le32_compile_time (GRUB_PE32_SCN_CNT_INITIALIZED_DATA
|
|
|
b1bcb2 |
| GRUB_PE32_SCN_MEM_DISCARDABLE
|