|
 |
4b8b04 |
From 3afaf579fb89ee4e1f6fc53f950e8ec574a9489a Mon Sep 17 00:00:00 2001
|
|
|
4b8b04 |
From: Hector Marco-Gisbert <hecmargi@upv.es>
|
|
|
4b8b04 |
Date: Fri, 13 Nov 2015 16:21:09 +0100
|
|
|
4b8b04 |
Subject: [PATCH 186/187] Fix security issue when reading username and password
|
|
|
4b8b04 |
|
|
|
4b8b04 |
This patch fixes two integer underflows at:
|
|
|
4b8b04 |
* grub-core/lib/crypto.c
|
|
|
4b8b04 |
* grub-core/normal/auth.c
|
|
|
4b8b04 |
|
|
|
4b8b04 |
Resolves: CVE-2015-8370
|
|
|
4b8b04 |
|
|
|
4b8b04 |
Signed-off-by: Hector Marco-Gisbert <hecmargi@upv.es>
|
|
|
4b8b04 |
Signed-off-by: Ismael Ripoll-Ripoll <iripoll@disca.upv.es>
|
|
|
4b8b04 |
---
|
|
|
4b8b04 |
grub-core/lib/crypto.c | 2 +-
|
|
|
4b8b04 |
grub-core/normal/auth.c | 2 +-
|
|
|
4b8b04 |
2 files changed, 2 insertions(+), 2 deletions(-)
|
|
|
4b8b04 |
|
|
|
4b8b04 |
diff --git a/grub-core/lib/crypto.c b/grub-core/lib/crypto.c
|
|
|
4b8b04 |
index 8e8426c..a23519c 100644
|
|
|
4b8b04 |
--- a/grub-core/lib/crypto.c
|
|
|
4b8b04 |
+++ b/grub-core/lib/crypto.c
|
|
|
4b8b04 |
@@ -456,7 +456,7 @@ grub_password_get (char buf[], unsigned buf_size)
|
|
|
4b8b04 |
break;
|
|
|
4b8b04 |
}
|
|
|
4b8b04 |
|
|
|
4b8b04 |
- if (key == '\b')
|
|
|
4b8b04 |
+ if (key == '\b' && cur_len)
|
|
|
4b8b04 |
{
|
|
|
4b8b04 |
cur_len--;
|
|
|
4b8b04 |
continue;
|
|
|
4b8b04 |
diff --git a/grub-core/normal/auth.c b/grub-core/normal/auth.c
|
|
|
4b8b04 |
index c6bd96e..5782ec5 100644
|
|
|
4b8b04 |
--- a/grub-core/normal/auth.c
|
|
|
4b8b04 |
+++ b/grub-core/normal/auth.c
|
|
|
4b8b04 |
@@ -172,7 +172,7 @@ grub_username_get (char buf[], unsigned buf_size)
|
|
|
4b8b04 |
break;
|
|
|
4b8b04 |
}
|
|
|
4b8b04 |
|
|
|
4b8b04 |
- if (key == '\b')
|
|
|
4b8b04 |
+ if (key == '\b' && cur_len)
|
|
|
4b8b04 |
{
|
|
|
4b8b04 |
cur_len--;
|
|
|
4b8b04 |
grub_printf ("\b");
|
|
|
4b8b04 |
--
|
|
|
4b8b04 |
2.5.0
|
|
|
4b8b04 |
|