|
 |
bc72d2 |
From 25bc75cbe63289864c09ab25144ee4af232bd8f4 Mon Sep 17 00:00:00 2001
|
|
|
bc72d2 |
From: =?UTF-8?q?Ale=C5=A1=20Mat=C4=9Bj?= <amatej@redhat.com>
|
|
|
bc72d2 |
Date: Mon, 4 Jul 2022 09:43:25 +0200
|
|
|
bc72d2 |
Subject: [PATCH] Add only relevant pkgs to upgrade transaction (RhBug:2097757)
|
|
|
bc72d2 |
|
|
|
bc72d2 |
https://bugzilla.redhat.com/show_bug.cgi?id=2097757
|
|
|
bc72d2 |
|
|
|
bc72d2 |
Without this patch dnf can create the following transaction during dnf upgrade --security when there is an advisory for B-2-2:
|
|
|
bc72d2 |
|
|
|
bc72d2 |
```
|
|
|
bc72d2 |
repo @System 0 testtags <inline>
|
|
|
bc72d2 |
#>=Pkg: A 1 1 x86_64
|
|
|
bc72d2 |
#>=Pkg: B 1 1 x86_64
|
|
|
bc72d2 |
#>=Req: A = 1-1
|
|
|
bc72d2 |
|
|
|
bc72d2 |
repo available 0 testtags <inline>
|
|
|
bc72d2 |
#>=Pkg: A 2 2 x86_64
|
|
|
bc72d2 |
#>=Pkg: B 2 2 x86_64
|
|
|
bc72d2 |
#>=Req: A = 2-2
|
|
|
bc72d2 |
system x86_64 rpm @System
|
|
|
bc72d2 |
job update oneof A-1-1.x86_64@@System B-2-2.x86_64@available [targeted,setevr,setarch]
|
|
|
bc72d2 |
result transaction,problems
|
|
|
bc72d2 |
```
|
|
|
bc72d2 |
|
|
|
bc72d2 |
Problem is that without forcebest nothing gets upgraded despite the available advisory and --security switch.
|
|
|
bc72d2 |
|
|
|
bc72d2 |
This can also be seen in CI test case: rpm-software-management/ci-dnf-stack#1130
|
|
|
bc72d2 |
---
|
|
|
bc72d2 |
dnf/base.py | 19 ++++++++++++++++++-
|
|
|
bc72d2 |
1 file changed, 18 insertions(+), 1 deletion(-)
|
|
|
bc72d2 |
|
|
|
bc72d2 |
diff --git a/dnf/base.py b/dnf/base.py
|
|
|
bc72d2 |
index 852fcdd8..82466831 100644
|
|
|
bc72d2 |
--- a/dnf/base.py
|
|
|
bc72d2 |
+++ b/dnf/base.py
|
|
|
bc72d2 |
@@ -2135,7 +2135,24 @@ class Base(object):
|
|
|
bc72d2 |
query.filterm(reponame=reponame)
|
|
|
bc72d2 |
query = self._merge_update_filters(query, pkg_spec=pkg_spec, upgrade=True)
|
|
|
bc72d2 |
if query:
|
|
|
bc72d2 |
- query = query.union(installed_query.latest())
|
|
|
bc72d2 |
+ # Given that we use libsolv's targeted transactions, we need to ensure that the transaction contains both
|
|
|
bc72d2 |
+ # the new targeted version and also the current installed version (for the upgraded package). This is
|
|
|
bc72d2 |
+ # because if it only contained the new version, libsolv would decide to reinstall the package even if it
|
|
|
bc72d2 |
+ # had just a different buildtime or vendor but the same version
|
|
|
bc72d2 |
+ # (https://github.com/openSUSE/libsolv/issues/287)
|
|
|
bc72d2 |
+ # - In general, the query already contains both the new and installed versions but not always.
|
|
|
bc72d2 |
+ # If repository-packages command is used, the installed packages are filtered out because they are from
|
|
|
bc72d2 |
+ # the @system repo. We need to add them back in.
|
|
|
bc72d2 |
+ # - However we need to add installed versions of just the packages that are being upgraded. We don't want
|
|
|
bc72d2 |
+ # to add all installed packages because it could increase the number of solutions for the transaction
|
|
|
bc72d2 |
+ # (especially without --best) and since libsolv prefers the smallest possible upgrade it could result
|
|
|
bc72d2 |
+ # in no upgrade even if there is one available. This is a problem in general but its critical with
|
|
|
bc72d2 |
+ # --security transactions (https://bugzilla.redhat.com/show_bug.cgi?id=2097757)
|
|
|
bc72d2 |
+ # - We want to add only the latest versions of installed packages, this is specifically for installonly
|
|
|
bc72d2 |
+ # packages. Otherwise if for example kernel-1 and kernel-3 were installed and present in the
|
|
|
bc72d2 |
+ # transaction libsolv could decide to install kernel-2 because it is an upgrade for kernel-1 even
|
|
|
bc72d2 |
+ # though we don't want it because there already is a newer version present.
|
|
|
bc72d2 |
+ query = query.union(installed_query.latest().filter(name=[pkg.name for pkg in query]))
|
|
|
bc72d2 |
sltr = dnf.selector.Selector(self.sack)
|
|
|
bc72d2 |
sltr.set(pkg=query)
|
|
|
bc72d2 |
self._goal.upgrade(select=sltr)
|
|
|
bc72d2 |
--
|
|
|
bc72d2 |
2.36.1
|
|
|
bc72d2 |
|