daandemeyer / rpms / systemd

Forked from rpms/systemd 2 years ago
Clone
698723
From c8b74ac5cf508c7bcec92d197880043af1d2bad7 Mon Sep 17 00:00:00 2001
698723
From: Lennart Poettering <lennart@poettering.net>
698723
Date: Tue, 9 Oct 2018 22:23:41 +0200
698723
Subject: [PATCH] logind: validate /run/user/1000 before we set it
698723
698723
Let's be safe than sorry, in particular as logind doesn't set it up
698723
anymore, but user-runtime-dir@.service does, and logind doesn't really
698723
track success of that.
698723
698723
(cherry picked from commit b92171124819305985ed292cc472f6668a027425)
698723
698723
Related: #1642460
698723
---
698723
 src/login/pam_systemd.c | 48 +++++++++++++++++++++++++++++++++++------
698723
 1 file changed, 41 insertions(+), 7 deletions(-)
698723
698723
diff --git a/src/login/pam_systemd.c b/src/login/pam_systemd.c
698723
index b2b62540bb..64e1b4d1bf 100644
698723
--- a/src/login/pam_systemd.c
698723
+++ b/src/login/pam_systemd.c
698723
@@ -319,6 +319,36 @@ static int update_environment(pam_handle_t *handle, const char *key, const char
698723
         return r;
698723
 }
698723
 
698723
+static bool validate_runtime_directory(pam_handle_t *handle, const char *path, uid_t uid) {
698723
+        struct stat st;
698723
+
698723
+        assert(path);
698723
+
698723
+        /* Just some extra paranoia: let's not set $XDG_RUNTIME_DIR if the directory we'd set it to isn't actually set
698723
+         * up properly for us. */
698723
+
698723
+        if (lstat(path, &st) < 0) {
698723
+                pam_syslog(handle, LOG_ERR, "Failed to stat() runtime directory '%s': %s", path, strerror(errno));
698723
+                goto fail;
698723
+        }
698723
+
698723
+        if (!S_ISDIR(st.st_mode)) {
698723
+                pam_syslog(handle, LOG_ERR, "Runtime directory '%s' is not actually a directory.", path);
698723
+                goto fail;
698723
+        }
698723
+
698723
+        if (st.st_uid != uid) {
698723
+                pam_syslog(handle, LOG_ERR, "Runtime directory '%s' is not owned by UID " UID_FMT ", as it should.", path, uid);
698723
+                goto fail;
698723
+        }
698723
+
698723
+        return true;
698723
+
698723
+fail:
698723
+        pam_syslog(handle, LOG_WARNING, "Not setting $XDG_RUNTIME_DIR, as the directory is not in order.");
698723
+        return false;
698723
+}
698723
+
698723
 _public_ PAM_EXTERN int pam_sm_open_session(
698723
                 pam_handle_t *handle,
698723
                 int flags,
698723
@@ -377,10 +407,12 @@ _public_ PAM_EXTERN int pam_sm_open_session(
698723
                 if (asprintf(&rt, "/run/user/"UID_FMT, pw->pw_uid) < 0)
698723
                         return PAM_BUF_ERR;
698723
 
698723
-                r = pam_misc_setenv(handle, "XDG_RUNTIME_DIR", rt, 0);
698723
-                if (r != PAM_SUCCESS) {
698723
-                        pam_syslog(handle, LOG_ERR, "Failed to set runtime dir.");
698723
-                        return r;
698723
+                if (validate_runtime_directory(handle, rt, pw->pw_uid)) {
698723
+                        r = pam_misc_setenv(handle, "XDG_RUNTIME_DIR", rt, 0);
698723
+                        if (r != PAM_SUCCESS) {
698723
+                                pam_syslog(handle, LOG_ERR, "Failed to set runtime dir.");
698723
+                                return r;
698723
+                        }
698723
                 }
698723
 
698723
                 r = export_legacy_dbus_address(handle, pw->pw_uid, rt);
698723
@@ -584,9 +616,11 @@ _public_ PAM_EXTERN int pam_sm_open_session(
698723
                  * in privileged apps clobbering the runtime directory
698723
                  * unnecessarily. */
698723
 
698723
-                r = update_environment(handle, "XDG_RUNTIME_DIR", runtime_path);
698723
-                if (r != PAM_SUCCESS)
698723
-                        return r;
698723
+                if (validate_runtime_directory(handle, runtime_path, pw->pw_uid)) {
698723
+                        r = update_environment(handle, "XDG_RUNTIME_DIR", runtime_path);
698723
+                        if (r != PAM_SUCCESS)
698723
+                                return r;
698723
+                }
698723
 
698723
                 r = export_legacy_dbus_address(handle, pw->pw_uid, runtime_path);
698723
                 if (r != PAM_SUCCESS)