daandemeyer / rpms / systemd

Forked from rpms/systemd 2 years ago
Clone
b677e7
From 9e9c6cbbdd60f4538cee041ffe3f9cd831c5de17 Mon Sep 17 00:00:00 2001
b677e7
From: Lennart Poettering <lennart@poettering.net>
b677e7
Date: Fri, 3 Aug 2018 20:21:27 +0200
b677e7
Subject: [PATCH] logind: improve logging in manager_connect_console()
b677e7
b677e7
let's make sure we log about every failure
b677e7
b677e7
Also, complain about systems where /dev/tty0 exists but
b677e7
/sys/class/tty/tty0/active does not. Such systems (usually container
b677e7
environments) are pretty broken as they mount something that is not a VC
b677e7
to /dev/tty0 and they really shouldn't.
b677e7
b677e7
Systems should either have a VC or not, but not badly fake one by
b677e7
mounting things wildly.
b677e7
b677e7
This just adds a warning message, as before we'll simply turn off VC
b677e7
handling in this case.
b677e7
b677e7
(cherry picked from commit 0b6d55cae9b8adc507fbea95d1b2874729a77386)
b677e7
b677e7
Related: #1642460
b677e7
---
b677e7
 src/login/logind.c | 22 +++++++++++-----------
b677e7
 1 file changed, 11 insertions(+), 11 deletions(-)
b677e7
b677e7
diff --git a/src/login/logind.c b/src/login/logind.c
b677e7
index 52fcee933c..1b366cd55f 100644
b677e7
--- a/src/login/logind.c
b677e7
+++ b/src/login/logind.c
b677e7
@@ -815,28 +815,28 @@ static int manager_connect_console(Manager *m) {
b677e7
         assert(m);
b677e7
         assert(m->console_active_fd < 0);
b677e7
 
b677e7
-        /* On certain architectures (S390 and Xen, and containers),
b677e7
-           /dev/tty0 does not exist, so don't fail if we can't open
b677e7
-           it. */
b677e7
+        /* On certain systems (such as S390, Xen, and containers) /dev/tty0 does not exist (as there is no VC), so
b677e7
+         * don't fail if we can't open it. */
b677e7
+
b677e7
         if (access("/dev/tty0", F_OK) < 0)
b677e7
                 return 0;
b677e7
 
b677e7
         m->console_active_fd = open("/sys/class/tty/tty0/active", O_RDONLY|O_NOCTTY|O_CLOEXEC);
b677e7
         if (m->console_active_fd < 0) {
b677e7
 
b677e7
-                /* On some systems the device node /dev/tty0 may exist
b677e7
-                 * even though /sys/class/tty/tty0 does not. */
b677e7
-                if (errno == ENOENT)
b677e7
+                /* On some systems /dev/tty0 may exist even though /sys/class/tty/tty0 does not. These are broken, but
b677e7
+                 * common. Let's complain but continue anyway. */
b677e7
+                if (errno == ENOENT) {
b677e7
+                        log_warning_errno(errno, "System has /dev/tty0 but not /sys/class/tty/tty0/active which is broken, ignoring: %m");
b677e7
                         return 0;
b677e7
+                }
b677e7
 
b677e7
                 return log_error_errno(errno, "Failed to open /sys/class/tty/tty0/active: %m");
b677e7
         }
b677e7
 
b677e7
         r = sd_event_add_io(m->event, &m->console_active_event_source, m->console_active_fd, 0, manager_dispatch_console, m);
b677e7
-        if (r < 0) {
b677e7
-                log_error("Failed to watch foreground console");
b677e7
-                return r;
b677e7
-        }
b677e7
+        if (r < 0)
b677e7
+                return log_error_errno(r, "Failed to watch foreground console: %m");
b677e7
 
b677e7
         /*
b677e7
          * SIGRTMIN is used as global VT-release signal, SIGRTMIN + 1 is used
b677e7
@@ -855,7 +855,7 @@ static int manager_connect_console(Manager *m) {
b677e7
 
b677e7
         r = sd_event_add_signal(m->event, NULL, SIGRTMIN, manager_vt_switch, m);
b677e7
         if (r < 0)
b677e7
-                return r;
b677e7
+                return log_error_errno(r, "Failed to subscribe to signal: %m");
b677e7
 
b677e7
         return 0;
b677e7
 }