daandemeyer / rpms / systemd

Forked from rpms/systemd 2 years ago
Clone
21255d
From 2f584bd93d64a75ab11b5a5aa31d0b7145da5a86 Mon Sep 17 00:00:00 2001
21255d
From: =?UTF-8?q?Zbigniew=20J=C4=99drzejewski-Szmek?= <zbyszek@in.waw.pl>
21255d
Date: Fri, 26 Apr 2019 13:37:31 +0200
21255d
Subject: [PATCH] basic/virt: try the /proc/1/sched hack also for PID1
21255d
21255d
If a container manager does not set $container, we could end up
21255d
in a strange situation when detect-virt returns container-other when
21255d
run as non-pid-1 and none when run as pid-1.
21255d
21255d
(cherry picked from commit 342bed02084c4396dd2f1054bd559bfb2699cfcb)
21255d
Resolves: #1868877
21255d
---
21255d
 src/basic/virt.c | 16 +++++++++++-----
21255d
 1 file changed, 11 insertions(+), 5 deletions(-)
21255d
21255d
diff --git a/src/basic/virt.c b/src/basic/virt.c
21255d
index e05b3e6d99..dfa1525219 100644
21255d
--- a/src/basic/virt.c
21255d
+++ b/src/basic/virt.c
21255d
@@ -427,7 +427,6 @@ finish:
21255d
 }
21255d
 
21255d
 int detect_container(void) {
21255d
-
21255d
         static const struct {
21255d
                 const char *value;
21255d
                 int id;
21255d
@@ -456,9 +455,15 @@ int detect_container(void) {
21255d
         }
21255d
 
21255d
         if (getpid_cached() == 1) {
21255d
-                /* If we are PID 1 we can just check our own environment variable, and that's authoritative. */
21255d
-
21255d
+                /* If we are PID 1 we can just check our own environment variable, and that's authoritative.
21255d
+                 * We distinguish three cases:
21255d
+                 * - the variable is not defined → we jump to other checks
21255d
+                 * - the variable is defined to an empty value → we are not in a container
21255d
+                 * - anything else → some container, either one of the known ones or "container-other"
21255d
+                 */
21255d
                 e = getenv("container");
21255d
+                if (!e)
21255d
+                        goto check_sched;
21255d
                 if (isempty(e)) {
21255d
                         r = VIRTUALIZATION_NONE;
21255d
                         goto finish;
21255d
@@ -486,8 +491,9 @@ int detect_container(void) {
21255d
         if (r < 0) /* This only works if we have CAP_SYS_PTRACE, hence let's better ignore failures here */
21255d
                 log_debug_errno(r, "Failed to read $container of PID 1, ignoring: %m");
21255d
 
21255d
-        /* Interestingly /proc/1/sched actually shows the host's PID for what we see as PID 1. Hence, if the PID shown
21255d
-         * there is not 1, we know we are in a PID namespace. and hence a container. */
21255d
+        /* Interestingly /proc/1/sched actually shows the host's PID for what we see as PID 1. If the PID
21255d
+         * shown there is not 1, we know we are in a PID namespace and hence a container. */
21255d
+ check_sched:
21255d
         r = read_one_line_file("/proc/1/sched", &m);
21255d
         if (r >= 0) {
21255d
                 const char *t;