daandemeyer / rpms / systemd

Forked from rpms/systemd 2 years ago
Clone
4fbe94
From daa0243fda679c8af723648b8b1e501fc55b0ada Mon Sep 17 00:00:00 2001
4fbe94
From: Michal Sekletar <msekleta@redhat.com>
4fbe94
Date: Wed, 22 May 2019 13:55:49 +0200
4fbe94
Subject: [PATCH] shared/cpu-set-util: make transfer of cpu_set_t over bus
4fbe94
 endian safe
4fbe94
4fbe94
(cherry picked from commit c367f996f5f091a63f812f0140b304c649be77fc)
4fbe94
4fbe94
Related: #1734787
4fbe94
---
4fbe94
 src/basic/cpu-set-util.c   | 38 ++++++++++++++++++++++++++++++++++++++
4fbe94
 src/basic/cpu-set-util.h   |  3 +++
4fbe94
 src/core/dbus-execute.c    |  6 +++++-
4fbe94
 src/shared/bus-unit-util.c |  8 +++++++-
4fbe94
 4 files changed, 53 insertions(+), 2 deletions(-)
4fbe94
4fbe94
diff --git a/src/basic/cpu-set-util.c b/src/basic/cpu-set-util.c
4fbe94
index c297eab032..74e35e57dd 100644
4fbe94
--- a/src/basic/cpu-set-util.c
4fbe94
+++ b/src/basic/cpu-set-util.c
4fbe94
@@ -209,3 +209,41 @@ int cpus_in_affinity_mask(void) {
4fbe94
                 n *= 2;
4fbe94
         }
4fbe94
 }
4fbe94
+
4fbe94
+int cpu_set_to_dbus(const CPUSet *set, uint8_t **ret, size_t *allocated) {
4fbe94
+        uint8_t *out;
4fbe94
+
4fbe94
+        assert(set);
4fbe94
+        assert(ret);
4fbe94
+
4fbe94
+        out = new0(uint8_t, set->allocated);
4fbe94
+        if (!out)
4fbe94
+                return -ENOMEM;
4fbe94
+
4fbe94
+        for (unsigned cpu = 0; cpu < set->allocated * 8; cpu++)
4fbe94
+                if (CPU_ISSET_S(cpu, set->allocated, set->set))
4fbe94
+                        out[cpu / 8] |= 1u << (cpu % 8);
4fbe94
+
4fbe94
+        *ret = out;
4fbe94
+        *allocated = set->allocated;
4fbe94
+        return 0;
4fbe94
+}
4fbe94
+
4fbe94
+int cpu_set_from_dbus(const uint8_t *bits, size_t size, CPUSet *set) {
4fbe94
+        _cleanup_(cpu_set_reset) CPUSet s = {};
4fbe94
+        int r;
4fbe94
+
4fbe94
+        assert(bits);
4fbe94
+        assert(set);
4fbe94
+
4fbe94
+        for (unsigned cpu = size * 8; cpu > 0; cpu--)
4fbe94
+                if (bits[(cpu - 1) / 8] & (1u << ((cpu - 1) % 8))) {
4fbe94
+                        r = cpu_set_add(&s, cpu - 1);
4fbe94
+                        if (r < 0)
4fbe94
+                                return r;
4fbe94
+                }
4fbe94
+
4fbe94
+        *set = s;
4fbe94
+        s = (CPUSet) {};
4fbe94
+        return 0;
4fbe94
+}
4fbe94
diff --git a/src/basic/cpu-set-util.h b/src/basic/cpu-set-util.h
4fbe94
index 68a73bf9f7..415c6ca295 100644
4fbe94
--- a/src/basic/cpu-set-util.h
4fbe94
+++ b/src/basic/cpu-set-util.h
4fbe94
@@ -46,4 +46,7 @@ static inline int parse_cpu_set(const char *rvalue, CPUSet *cpu_set){
4fbe94
         return parse_cpu_set_full(rvalue, cpu_set, false, NULL, NULL, 0, NULL);
4fbe94
 }
4fbe94
 
4fbe94
+int cpu_set_to_dbus(const CPUSet *set, uint8_t **ret, size_t *allocated);
4fbe94
+int cpu_set_from_dbus(const uint8_t *bits, size_t size, CPUSet *set);
4fbe94
+
4fbe94
 int cpus_in_affinity_mask(void);
4fbe94
diff --git a/src/core/dbus-execute.c b/src/core/dbus-execute.c
4fbe94
index 08946627e3..50ea71a281 100644
4fbe94
--- a/src/core/dbus-execute.c
4fbe94
+++ b/src/core/dbus-execute.c
4fbe94
@@ -1553,18 +1553,22 @@ int bus_exec_context_set_transient_property(
4fbe94
         if (streq(name, "CPUAffinity")) {
4fbe94
                 const void *a;
4fbe94
                 size_t n;
4fbe94
+                _cleanup_(cpu_set_reset) CPUSet set = {};
4fbe94
 
4fbe94
                 r = sd_bus_message_read_array(message, 'y', &a, &n);
4fbe94
                 if (r < 0)
4fbe94
                         return r;
4fbe94
 
4fbe94
+                r = cpu_set_from_dbus(a, n, &set);
4fbe94
+                if (r < 0)
4fbe94
+                        return r;
4fbe94
+
4fbe94
                 if (!UNIT_WRITE_FLAGS_NOOP(flags)) {
4fbe94
                         if (n == 0) {
4fbe94
                                 cpu_set_reset(&c->cpu_set);
4fbe94
                                 unit_write_settingf(u, flags, name, "%s=", name);
4fbe94
                         } else {
4fbe94
                                 _cleanup_free_ char *str = NULL;
4fbe94
-                                const CPUSet set = {(cpu_set_t*) a, n};
4fbe94
 
4fbe94
                                 str = cpu_set_to_string(&set);
4fbe94
                                 if (!str)
4fbe94
diff --git a/src/shared/bus-unit-util.c b/src/shared/bus-unit-util.c
4fbe94
index 75b4aace84..ec8732c226 100644
4fbe94
--- a/src/shared/bus-unit-util.c
4fbe94
+++ b/src/shared/bus-unit-util.c
4fbe94
@@ -933,12 +933,18 @@ static int bus_append_execute_property(sd_bus_message *m, const char *field, con
4fbe94
 
4fbe94
         if (streq(field, "CPUAffinity")) {
4fbe94
                 _cleanup_(cpu_set_reset) CPUSet cpuset = {};
4fbe94
+                _cleanup_free_ uint8_t *array = NULL;
4fbe94
+                size_t allocated;
4fbe94
 
4fbe94
                 r = parse_cpu_set(eq, &cpuset);
4fbe94
                 if (r < 0)
4fbe94
                         return log_error_errno(r, "Failed to parse %s value: %s", field, eq);
4fbe94
 
4fbe94
-                return bus_append_byte_array(m, field, cpuset.set, cpuset.allocated);
4fbe94
+                r = cpu_set_to_dbus(&cpuset, &array, &allocated);
4fbe94
+                if (r < 0)
4fbe94
+                        return log_error_errno(r, "Failed to serialize CPUAffinity: %m");
4fbe94
+
4fbe94
+                return bus_append_byte_array(m, field, array, allocated);
4fbe94
         }
4fbe94
 
4fbe94
         if (STR_IN_SET(field, "RestrictAddressFamilies", "SystemCallFilter")) {