daandemeyer / rpms / systemd

Forked from rpms/systemd 2 years ago
Clone
ff6046
From b53f89d56a5b7528735ddf335f8b47ab3e1a947a Mon Sep 17 00:00:00 2001
ff6046
From: Lennart Poettering <lennart@poettering.net>
ff6046
Date: Fri, 19 Oct 2018 11:31:37 +0200
ff6046
Subject: [PATCH] test: add test case for recursive chown()ing
ff6046
ff6046
[msekleta: I removed call to log_test_skipped() and replaced it with older construct log_info() + return EXIT_TEST_SKIP]
ff6046
ff6046
(cherry-picked from commit cb9e44db36caefcbb8ee7a12e14217305ed69ff2)
ff6046
ff6046
Related: #1643368
ff6046
---
ff6046
 src/test/meson.build      |   5 ++
ff6046
 src/test/test-chown-rec.c | 162 ++++++++++++++++++++++++++++++++++++++
ff6046
 2 files changed, 167 insertions(+)
ff6046
 create mode 100644 src/test/test-chown-rec.c
ff6046
ff6046
diff --git a/src/test/meson.build b/src/test/meson.build
ff6046
index 7da7e3a22c..b982251b1f 100644
ff6046
--- a/src/test/meson.build
ff6046
+++ b/src/test/meson.build
ff6046
@@ -60,6 +60,11 @@ tests += [
ff6046
           libmount,
ff6046
           libblkid]],
ff6046
 
ff6046
+        [['src/test/test-chown-rec.c'],
ff6046
+         [libcore,
ff6046
+          libshared],
ff6046
+         []],
ff6046
+
ff6046
         [['src/test/test-job-type.c'],
ff6046
          [libcore,
ff6046
           libshared],
ff6046
diff --git a/src/test/test-chown-rec.c b/src/test/test-chown-rec.c
ff6046
new file mode 100644
ff6046
index 0000000000..f16d4d4ba2
ff6046
--- /dev/null
ff6046
+++ b/src/test/test-chown-rec.c
ff6046
@@ -0,0 +1,162 @@
ff6046
+/* SPDX-License-Identifier: LGPL-2.1+ */
ff6046
+
ff6046
+#include <sys/xattr.h>
ff6046
+
ff6046
+#include "alloc-util.h"
ff6046
+#include "chown-recursive.h"
ff6046
+#include "fileio.h"
ff6046
+#include "log.h"
ff6046
+#include "rm-rf.h"
ff6046
+#include "string-util.h"
ff6046
+#include "tests.h"
ff6046
+
ff6046
+static const uint8_t acl[] = {
ff6046
+        0x02, 0x00, 0x00, 0x00, 0x01, 0x00, 0x07, 0x00,
ff6046
+        0xff, 0xff, 0xff, 0xff, 0x02, 0x00, 0x07, 0x00,
ff6046
+        0x02, 0x00, 0x00, 0x00, 0x04, 0x00, 0x07, 0x00,
ff6046
+        0xff, 0xff, 0xff, 0xff, 0x10, 0x00, 0x07, 0x00,
ff6046
+        0xff, 0xff, 0xff, 0xff, 0x20, 0x00, 0x05, 0x00,
ff6046
+        0xff, 0xff, 0xff, 0xff,
ff6046
+};
ff6046
+
ff6046
+static const uint8_t default_acl[] = {
ff6046
+        0x02, 0x00, 0x00, 0x00, 0x01, 0x00, 0x07, 0x00,
ff6046
+        0xff, 0xff, 0xff, 0xff, 0x04, 0x00, 0x07, 0x00,
ff6046
+        0xff, 0xff, 0xff, 0xff, 0x08, 0x00, 0x07, 0x00,
ff6046
+        0x04, 0x00, 0x00, 0x00, 0x10, 0x00, 0x07, 0x00,
ff6046
+        0xff, 0xff, 0xff, 0xff, 0x20, 0x00, 0x05, 0x00,
ff6046
+        0xff, 0xff, 0xff, 0xff,
ff6046
+};
ff6046
+
ff6046
+static bool has_xattr(const char *p) {
ff6046
+        char buffer[sizeof(acl) * 4];
ff6046
+
ff6046
+        if (lgetxattr(p, "system.posix_acl_access", buffer, sizeof(buffer)) < 0) {
ff6046
+                if (IN_SET(errno, EOPNOTSUPP, ENOTTY, ENODATA, ENOSYS))
ff6046
+                        return false;
ff6046
+        }
ff6046
+
ff6046
+        return true;
ff6046
+}
ff6046
+
ff6046
+static void test_chown_recursive(void) {
ff6046
+        _cleanup_(rm_rf_physical_and_freep) char *t = NULL;
ff6046
+        struct stat st;
ff6046
+        const char *p;
ff6046
+
ff6046
+        umask(022);
ff6046
+        assert_se(mkdtemp_malloc(NULL, &t) >= 0);
ff6046
+
ff6046
+        p = strjoina(t, "/dir");
ff6046
+        assert_se(mkdir(p, 0777) >= 0);
ff6046
+        assert_se(lstat(p, &st) >= 0);
ff6046
+        assert_se(S_ISDIR(st.st_mode));
ff6046
+        assert_se((st.st_mode & 07777) == 0755);
ff6046
+        assert_se(st.st_uid == 0);
ff6046
+        assert_se(st.st_gid == 0);
ff6046
+        assert_se(!has_xattr(p));
ff6046
+
ff6046
+        p = strjoina(t, "/dir/symlink");
ff6046
+        assert_se(symlink("../../", p) >= 0);
ff6046
+        assert_se(lstat(p, &st) >= 0);
ff6046
+        assert_se(S_ISLNK(st.st_mode));
ff6046
+        assert_se((st.st_mode & 07777) == 0777);
ff6046
+        assert_se(st.st_uid == 0);
ff6046
+        assert_se(st.st_gid == 0);
ff6046
+        assert_se(!has_xattr(p));
ff6046
+
ff6046
+        p = strjoina(t, "/dir/reg");
ff6046
+        assert_se(mknod(p, S_IFREG|0777, 0) >= 0);
ff6046
+        assert_se(lstat(p, &st) >= 0);
ff6046
+        assert_se(S_ISREG(st.st_mode));
ff6046
+        assert_se((st.st_mode & 07777) == 0755);
ff6046
+        assert_se(st.st_uid == 0);
ff6046
+        assert_se(st.st_gid == 0);
ff6046
+        assert_se(!has_xattr(p));
ff6046
+
ff6046
+        p = strjoina(t, "/dir/sock");
ff6046
+        assert_se(mknod(p, S_IFSOCK|0777, 0) >= 0);
ff6046
+        assert_se(lstat(p, &st) >= 0);
ff6046
+        assert_se(S_ISSOCK(st.st_mode));
ff6046
+        assert_se((st.st_mode & 07777) == 0755);
ff6046
+        assert_se(st.st_uid == 0);
ff6046
+        assert_se(st.st_gid == 0);
ff6046
+        assert_se(!has_xattr(p));
ff6046
+
ff6046
+        p = strjoina(t, "/dir/fifo");
ff6046
+        assert_se(mknod(p, S_IFIFO|0777, 0) >= 0);
ff6046
+        assert_se(lstat(p, &st) >= 0);
ff6046
+        assert_se(S_ISFIFO(st.st_mode));
ff6046
+        assert_se((st.st_mode & 07777) == 0755);
ff6046
+        assert_se(st.st_uid == 0);
ff6046
+        assert_se(st.st_gid == 0);
ff6046
+        assert_se(!has_xattr(p));
ff6046
+
ff6046
+        /* We now apply an xattr to the dir, and check it again */
ff6046
+        p = strjoina(t, "/dir");
ff6046
+        assert_se(setxattr(p, "system.posix_acl_access", acl, sizeof(acl), 0) >= 0);
ff6046
+        assert_se(setxattr(p, "system.posix_acl_default", default_acl, sizeof(default_acl), 0) >= 0);
ff6046
+        assert_se(lstat(p, &st) >= 0);
ff6046
+        assert_se(S_ISDIR(st.st_mode));
ff6046
+        assert_se((st.st_mode & 07777) == 0775); /* acl change changed the mode too */
ff6046
+        assert_se(st.st_uid == 0);
ff6046
+        assert_se(st.st_gid == 0);
ff6046
+        assert_se(has_xattr(p));
ff6046
+
ff6046
+        assert_se(path_chown_recursive(t, 1, 2) >= 0);
ff6046
+
ff6046
+        p = strjoina(t, "/dir");
ff6046
+        assert_se(lstat(p, &st) >= 0);
ff6046
+        assert_se(S_ISDIR(st.st_mode));
ff6046
+        assert_se((st.st_mode & 07777) == 0775);
ff6046
+        assert_se(st.st_uid == 1);
ff6046
+        assert_se(st.st_gid == 2);
ff6046
+        assert_se(!has_xattr(p));
ff6046
+
ff6046
+        p = strjoina(t, "/dir/symlink");
ff6046
+        assert_se(lstat(p, &st) >= 0);
ff6046
+        assert_se(S_ISLNK(st.st_mode));
ff6046
+        assert_se((st.st_mode & 07777) == 0777);
ff6046
+        assert_se(st.st_uid == 1);
ff6046
+        assert_se(st.st_gid == 2);
ff6046
+        assert_se(!has_xattr(p));
ff6046
+
ff6046
+        p = strjoina(t, "/dir/reg");
ff6046
+        assert_se(lstat(p, &st) >= 0);
ff6046
+        assert_se(S_ISREG(st.st_mode));
ff6046
+        assert_se((st.st_mode & 07777) == 0755);
ff6046
+        assert_se(st.st_uid == 1);
ff6046
+        assert_se(st.st_gid == 2);
ff6046
+        assert_se(!has_xattr(p));
ff6046
+
ff6046
+        p = strjoina(t, "/dir/sock");
ff6046
+        assert_se(lstat(p, &st) >= 0);
ff6046
+        assert_se(S_ISSOCK(st.st_mode));
ff6046
+        assert_se((st.st_mode & 07777) == 0755);
ff6046
+        assert_se(st.st_uid == 1);
ff6046
+        assert_se(st.st_gid == 2);
ff6046
+        assert_se(!has_xattr(p));
ff6046
+
ff6046
+        p = strjoina(t, "/dir/fifo");
ff6046
+        assert_se(lstat(p, &st) >= 0);
ff6046
+        assert_se(S_ISFIFO(st.st_mode));
ff6046
+        assert_se((st.st_mode & 07777) == 0755);
ff6046
+        assert_se(st.st_uid == 1);
ff6046
+        assert_se(st.st_gid == 2);
ff6046
+        assert_se(!has_xattr(p));
ff6046
+}
ff6046
+
ff6046
+int main(int argc, char *argv[]) {
ff6046
+        log_set_max_level(LOG_DEBUG);
ff6046
+        log_parse_environment();
ff6046
+        log_open();
ff6046
+
ff6046
+        if (geteuid() != 0) {
ff6046
+                log_info("not running as root");
ff6046
+                return EXIT_TEST_SKIP;
ff6046
+        }
ff6046
+
ff6046
+        test_chown_recursive();
ff6046
+
ff6046
+        return EXIT_SUCCESS;
ff6046
+}