From cbfdbd7430e27c24d55b880144d5df05ef949417 Mon Sep 17 00:00:00 2001 From: "Daniel P. Berrange" Date: Thu, 8 Feb 2018 17:50:31 +0100 Subject: [PATCH 17/27] ui: avoid pointless VNC updates if framebuffer isn't dirty MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit RH-Author: Daniel P. Berrange Message-id: <20180208175041.5634-18-berrange@redhat.com> Patchwork-id: 78946 O-Subject: [RHEL-7.5 qemu-kvm PATCH v1 17/27] ui: avoid pointless VNC updates if framebuffer isn't dirty Bugzilla: 1527405 RH-Acked-by: Laszlo Ersek RH-Acked-by: Gerd Hoffmann RH-Acked-by: Miroslav Rezanina From: "Daniel P. Berrange" The vnc_update_client() method checks the 'has_dirty' flag to see if there are dirty regions that are pending to send to the client. Regardless of this flag, if a forced update is requested, updates must be sent. For unknown reasons though, the code also tries to sent updates if audio capture is enabled. This makes no sense as audio capture state does not impact framebuffer contents, so this check is removed. Signed-off-by: Daniel P. Berrange Reviewed-by: Darren Kenny Reviewed-by: Marc-André Lureau Message-id: 20171218191228.31018-5-berrange@redhat.com Signed-off-by: Gerd Hoffmann (cherry picked from commit 3541b08475d51bddf8aded36576a0ff5a547a978) Signed-off-by: Miroslav Rezanina --- ui/vnc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ui/vnc.c b/ui/vnc.c index aebaa37..eea5702 100644 --- a/ui/vnc.c +++ b/ui/vnc.c @@ -869,7 +869,7 @@ static int vnc_update_client(VncState *vs, int has_dirty) return 0; } - if (!vs->has_dirty && !vs->audio_cap && !vs->force_update) { + if (!vs->has_dirty && !vs->force_update) { return 0; } -- 1.8.3.1