|
 |
22c213 |
From 9a44d78f5019280b006bb5b3de7164336289d639 Mon Sep 17 00:00:00 2001
|
|
|
22c213 |
From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
|
|
|
22c213 |
Date: Mon, 27 Jan 2020 19:02:21 +0100
|
|
|
22c213 |
Subject: [PATCH 110/116] virtiofsd: fix lo_destroy() resource leaks
|
|
|
22c213 |
MIME-Version: 1.0
|
|
|
22c213 |
Content-Type: text/plain; charset=UTF-8
|
|
|
22c213 |
Content-Transfer-Encoding: 8bit
|
|
|
22c213 |
|
|
|
22c213 |
RH-Author: Dr. David Alan Gilbert <dgilbert@redhat.com>
|
|
|
22c213 |
Message-id: <20200127190227.40942-107-dgilbert@redhat.com>
|
|
|
22c213 |
Patchwork-id: 93560
|
|
|
22c213 |
O-Subject: [RHEL-AV-8.2 qemu-kvm PATCH 106/112] virtiofsd: fix lo_destroy() resource leaks
|
|
|
22c213 |
Bugzilla: 1694164
|
|
|
22c213 |
RH-Acked-by: Philippe Mathieu-Daudé <philmd@redhat.com>
|
|
|
22c213 |
RH-Acked-by: Stefan Hajnoczi <stefanha@redhat.com>
|
|
|
22c213 |
RH-Acked-by: Sergio Lopez Pascual <slp@redhat.com>
|
|
|
22c213 |
|
|
|
22c213 |
From: Stefan Hajnoczi <stefanha@redhat.com>
|
|
|
22c213 |
|
|
|
22c213 |
Now that lo_destroy() is serialized we can call unref_inode() so that
|
|
|
22c213 |
all inode resources are freed.
|
|
|
22c213 |
|
|
|
22c213 |
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
|
|
|
22c213 |
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
|
|
|
22c213 |
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
|
|
|
22c213 |
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
|
|
|
22c213 |
(cherry picked from commit 28f7a3b026f231bfe8de5fed6a18a8d27b1dfcee)
|
|
|
22c213 |
Signed-off-by: Miroslav Rezanina <mrezanin@redhat.com>
|
|
|
22c213 |
---
|
|
|
22c213 |
tools/virtiofsd/passthrough_ll.c | 41 ++++++++++++++++++++--------------------
|
|
|
22c213 |
1 file changed, 20 insertions(+), 21 deletions(-)
|
|
|
22c213 |
|
|
|
22c213 |
diff --git a/tools/virtiofsd/passthrough_ll.c b/tools/virtiofsd/passthrough_ll.c
|
|
|
22c213 |
index 79b8b71..eb001b9 100644
|
|
|
22c213 |
--- a/tools/virtiofsd/passthrough_ll.c
|
|
|
22c213 |
+++ b/tools/virtiofsd/passthrough_ll.c
|
|
|
22c213 |
@@ -1371,26 +1371,6 @@ static void unref_inode_lolocked(struct lo_data *lo, struct lo_inode *inode,
|
|
|
22c213 |
}
|
|
|
22c213 |
}
|
|
|
22c213 |
|
|
|
22c213 |
-static int unref_all_inodes_cb(gpointer key, gpointer value, gpointer user_data)
|
|
|
22c213 |
-{
|
|
|
22c213 |
- struct lo_inode *inode = value;
|
|
|
22c213 |
- struct lo_data *lo = user_data;
|
|
|
22c213 |
-
|
|
|
22c213 |
- inode->nlookup = 0;
|
|
|
22c213 |
- lo_map_remove(&lo->ino_map, inode->fuse_ino);
|
|
|
22c213 |
- close(inode->fd);
|
|
|
22c213 |
- lo_inode_put(lo, &inode;; /* Drop our refcount from lo_do_lookup() */
|
|
|
22c213 |
-
|
|
|
22c213 |
- return TRUE;
|
|
|
22c213 |
-}
|
|
|
22c213 |
-
|
|
|
22c213 |
-static void unref_all_inodes(struct lo_data *lo)
|
|
|
22c213 |
-{
|
|
|
22c213 |
- pthread_mutex_lock(&lo->mutex);
|
|
|
22c213 |
- g_hash_table_foreach_remove(lo->inodes, unref_all_inodes_cb, lo);
|
|
|
22c213 |
- pthread_mutex_unlock(&lo->mutex);
|
|
|
22c213 |
-}
|
|
|
22c213 |
-
|
|
|
22c213 |
static void lo_forget_one(fuse_req_t req, fuse_ino_t ino, uint64_t nlookup)
|
|
|
22c213 |
{
|
|
|
22c213 |
struct lo_data *lo = lo_data(req);
|
|
|
22c213 |
@@ -2477,7 +2457,26 @@ static void lo_lseek(fuse_req_t req, fuse_ino_t ino, off_t off, int whence,
|
|
|
22c213 |
static void lo_destroy(void *userdata)
|
|
|
22c213 |
{
|
|
|
22c213 |
struct lo_data *lo = (struct lo_data *)userdata;
|
|
|
22c213 |
- unref_all_inodes(lo);
|
|
|
22c213 |
+
|
|
|
22c213 |
+ /*
|
|
|
22c213 |
+ * Normally lo->mutex must be taken when traversing lo->inodes but
|
|
|
22c213 |
+ * lo_destroy() is a serialized request so no races are possible here.
|
|
|
22c213 |
+ *
|
|
|
22c213 |
+ * In addition, we cannot acquire lo->mutex since unref_inode() takes it
|
|
|
22c213 |
+ * too and this would result in a recursive lock.
|
|
|
22c213 |
+ */
|
|
|
22c213 |
+ while (true) {
|
|
|
22c213 |
+ GHashTableIter iter;
|
|
|
22c213 |
+ gpointer key, value;
|
|
|
22c213 |
+
|
|
|
22c213 |
+ g_hash_table_iter_init(&iter, lo->inodes);
|
|
|
22c213 |
+ if (!g_hash_table_iter_next(&iter, &key, &value)) {
|
|
|
22c213 |
+ break;
|
|
|
22c213 |
+ }
|
|
|
22c213 |
+
|
|
|
22c213 |
+ struct lo_inode *inode = value;
|
|
|
22c213 |
+ unref_inode_lolocked(lo, inode, inode->nlookup);
|
|
|
22c213 |
+ }
|
|
|
22c213 |
}
|
|
|
22c213 |
|
|
|
22c213 |
static struct fuse_lowlevel_ops lo_oper = {
|
|
|
22c213 |
--
|
|
|
22c213 |
1.8.3.1
|
|
|
22c213 |
|