|
 |
b38b0f |
From 231d80e36c0788378d87ad4ee376ea87dc43745d Mon Sep 17 00:00:00 2001
|
|
|
b38b0f |
From: Cornelia Huck <cohuck@redhat.com>
|
|
|
b38b0f |
Date: Wed, 17 Apr 2019 13:57:30 +0100
|
|
|
b38b0f |
Subject: [PATCH 13/24] s390x/pci: Ignore the unplug call if we already have a
|
|
|
b38b0f |
release_timer
|
|
|
b38b0f |
|
|
|
b38b0f |
RH-Author: Cornelia Huck <cohuck@redhat.com>
|
|
|
b38b0f |
Message-id: <20190417135741.25297-14-cohuck@redhat.com>
|
|
|
b38b0f |
Patchwork-id: 85791
|
|
|
b38b0f |
O-Subject: [RHEL-8.1.0 qemu-kvm PATCH v2 13/24] s390x/pci: Ignore the unplug call if we already have a release_timer
|
|
|
b38b0f |
Bugzilla: 1699070
|
|
|
b38b0f |
RH-Acked-by: David Hildenbrand <david@redhat.com>
|
|
|
b38b0f |
RH-Acked-by: Thomas Huth <thuth@redhat.com>
|
|
|
b38b0f |
RH-Acked-by: Jens Freimann <jfreimann@redhat.com>
|
|
|
b38b0f |
|
|
|
b38b0f |
From: David Hildenbrand <david@redhat.com>
|
|
|
b38b0f |
|
|
|
b38b0f |
... otherwise two successive calls to qdev_unplug() (e.g. by an impatient
|
|
|
b38b0f |
user) will effectively overwrite pbdev->release_timer, resulting in a
|
|
|
b38b0f |
memory leak. We are already processing the unplug.
|
|
|
b38b0f |
|
|
|
b38b0f |
If there is already a release_timer, the unplug will be performed after
|
|
|
b38b0f |
the timeout.
|
|
|
b38b0f |
|
|
|
b38b0f |
Can be easily triggered by
|
|
|
b38b0f |
(hmp) device_add virtio-mouse-pci,id=test
|
|
|
b38b0f |
(hmp) stop
|
|
|
b38b0f |
(hmp) device_del test
|
|
|
b38b0f |
(hmp) device_del test
|
|
|
b38b0f |
|
|
|
b38b0f |
Signed-off-by: David Hildenbrand <david@redhat.com>
|
|
|
b38b0f |
Message-Id: <20190114103110.10909-5-david@redhat.com>
|
|
|
b38b0f |
Reviewed-by: Collin Walling <walling@linux.ibm.com>
|
|
|
b38b0f |
Signed-off-by: Cornelia Huck <cohuck@redhat.com>
|
|
|
b38b0f |
(cherry picked from commit 3549f8c9e4f0ef1c3417ff43b2164f68ad34b922)
|
|
|
b38b0f |
Signed-off-by: Cornelia Huck <cohuck@redhat.com>
|
|
|
b38b0f |
Signed-off-by: Danilo C. L. de Paula <ddepaula@redhat.com>
|
|
|
b38b0f |
---
|
|
|
b38b0f |
hw/s390x/s390-pci-bus.c | 3 +++
|
|
|
b38b0f |
1 file changed, 3 insertions(+)
|
|
|
b38b0f |
|
|
|
b38b0f |
diff --git a/hw/s390x/s390-pci-bus.c b/hw/s390x/s390-pci-bus.c
|
|
|
b38b0f |
index ea0c74c..24a0d78 100644
|
|
|
b38b0f |
--- a/hw/s390x/s390-pci-bus.c
|
|
|
b38b0f |
+++ b/hw/s390x/s390-pci-bus.c
|
|
|
b38b0f |
@@ -972,6 +972,9 @@ static void s390_pcihost_unplug(HotplugHandler *hotplug_dev, DeviceState *dev,
|
|
|
b38b0f |
case ZPCI_FS_STANDBY:
|
|
|
b38b0f |
break;
|
|
|
b38b0f |
default:
|
|
|
b38b0f |
+ if (pbdev->release_timer) {
|
|
|
b38b0f |
+ return;
|
|
|
b38b0f |
+ }
|
|
|
b38b0f |
s390_pci_generate_plug_event(HP_EVENT_DECONFIGURE_REQUEST,
|
|
|
b38b0f |
pbdev->fh, pbdev->fid);
|
|
|
b38b0f |
pbdev->release_timer = timer_new_ns(QEMU_CLOCK_VIRTUAL,
|
|
|
b38b0f |
--
|
|
|
b38b0f |
1.8.3.1
|
|
|
b38b0f |
|