cryptospore / rpms / qemu-kvm

Forked from rpms/qemu-kvm 2 years ago
Clone
9ae3a8
From aa1df6fcd4c2dbfd39cac3e1d68208cca61643ce Mon Sep 17 00:00:00 2001
9ae3a8
From: Max Reitz <mreitz@redhat.com>
9ae3a8
Date: Sat, 13 Jun 2015 16:22:23 +0200
9ae3a8
Subject: [PATCH 29/42] qcow2: Clean up after refcount rebuild
9ae3a8
9ae3a8
Message-id: <1434212556-3927-30-git-send-email-mreitz@redhat.com>
9ae3a8
Patchwork-id: 66048
9ae3a8
O-Subject: [RHEL-7.2 qemu-kvm PATCH 29/42] qcow2: Clean up after refcount rebuild
9ae3a8
Bugzilla: 1129893
9ae3a8
RH-Acked-by: Jeffrey Cody <jcody@redhat.com>
9ae3a8
RH-Acked-by: Fam Zheng <famz@redhat.com>
9ae3a8
RH-Acked-by: Stefan Hajnoczi <stefanha@redhat.com>
9ae3a8
9ae3a8
BZ: 1129893
9ae3a8
9ae3a8
Because the old refcount structure will be leaked after having rebuilt
9ae3a8
it, we need to recalculate the refcounts and run a leak-fixing operation
9ae3a8
afterwards (if leaks should be fixed at all).
9ae3a8
9ae3a8
Signed-off-by: Max Reitz <mreitz@redhat.com>
9ae3a8
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
9ae3a8
(cherry picked from commit 791230d8bbd5c09d80845755a54074cd2d8b5a22)
9ae3a8
9ae3a8
Signed-off-by: Max Reitz <mreitz@redhat.com>
9ae3a8
Signed-off-by: Miroslav Rezanina <mrezanin@redhat.com>
9ae3a8
---
9ae3a8
 block/qcow2-refcount.c | 45 +++++++++++++++++++++++++++++++++++++++++++++
9ae3a8
 1 file changed, 45 insertions(+)
9ae3a8
9ae3a8
diff --git a/block/qcow2-refcount.c b/block/qcow2-refcount.c
9ae3a8
index 651ddb6..fe36bbd 100644
9ae3a8
--- a/block/qcow2-refcount.c
9ae3a8
+++ b/block/qcow2-refcount.c
9ae3a8
@@ -1983,12 +1983,57 @@ int qcow2_check_refcounts(BlockDriverState *bs, BdrvCheckResult *res,
9ae3a8
                       nb_clusters);
9ae3a8
 
9ae3a8
     if (rebuild && (fix & BDRV_FIX_ERRORS)) {
9ae3a8
+        BdrvCheckResult old_res = *res;
9ae3a8
+        int fresh_leaks = 0;
9ae3a8
+
9ae3a8
         fprintf(stderr, "Rebuilding refcount structure\n");
9ae3a8
         ret = rebuild_refcount_structure(bs, res, &refcount_table,
9ae3a8
                                          &nb_clusters);
9ae3a8
         if (ret < 0) {
9ae3a8
             goto fail;
9ae3a8
         }
9ae3a8
+
9ae3a8
+        res->corruptions = 0;
9ae3a8
+        res->leaks = 0;
9ae3a8
+
9ae3a8
+        /* Because the old reftable has been exchanged for a new one the
9ae3a8
+         * references have to be recalculated */
9ae3a8
+        rebuild = false;
9ae3a8
+        memset(refcount_table, 0, nb_clusters * sizeof(uint16_t));
9ae3a8
+        ret = calculate_refcounts(bs, res, 0, &rebuild, &refcount_table,
9ae3a8
+                                  &nb_clusters);
9ae3a8
+        if (ret < 0) {
9ae3a8
+            goto fail;
9ae3a8
+        }
9ae3a8
+
9ae3a8
+        if (fix & BDRV_FIX_LEAKS) {
9ae3a8
+            /* The old refcount structures are now leaked, fix it; the result
9ae3a8
+             * can be ignored, aside from leaks which were introduced by
9ae3a8
+             * rebuild_refcount_structure() that could not be fixed */
9ae3a8
+            BdrvCheckResult saved_res = *res;
9ae3a8
+            *res = (BdrvCheckResult){ 0 };
9ae3a8
+
9ae3a8
+            compare_refcounts(bs, res, BDRV_FIX_LEAKS, &rebuild,
9ae3a8
+                              &highest_cluster, refcount_table, nb_clusters);
9ae3a8
+            if (rebuild) {
9ae3a8
+                fprintf(stderr, "ERROR rebuilt refcount structure is still "
9ae3a8
+                        "broken\n");
9ae3a8
+            }
9ae3a8
+
9ae3a8
+            /* Any leaks accounted for here were introduced by
9ae3a8
+             * rebuild_refcount_structure() because that function has created a
9ae3a8
+             * new refcount structure from scratch */
9ae3a8
+            fresh_leaks = res->leaks;
9ae3a8
+            *res = saved_res;
9ae3a8
+        }
9ae3a8
+
9ae3a8
+        if (res->corruptions < old_res.corruptions) {
9ae3a8
+            res->corruptions_fixed += old_res.corruptions - res->corruptions;
9ae3a8
+        }
9ae3a8
+        if (res->leaks < old_res.leaks) {
9ae3a8
+            res->leaks_fixed += old_res.leaks - res->leaks;
9ae3a8
+        }
9ae3a8
+        res->leaks += fresh_leaks;
9ae3a8
     } else if (fix) {
9ae3a8
         if (rebuild) {
9ae3a8
             fprintf(stderr, "ERROR need to rebuild refcount structures\n");
9ae3a8
-- 
9ae3a8
1.8.3.1
9ae3a8