|
 |
902636 |
From 5770fe43fe1e15e6f53cfd3705605e8645b95a98 Mon Sep 17 00:00:00 2001
|
|
|
902636 |
From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
|
|
|
902636 |
Date: Fri, 13 Mar 2020 17:17:08 +0000
|
|
|
902636 |
Subject: [PATCH 20/20] exec/rom_reset: Free rom data during inmigrate skip
|
|
|
902636 |
MIME-Version: 1.0
|
|
|
902636 |
Content-Type: text/plain; charset=UTF-8
|
|
|
902636 |
Content-Transfer-Encoding: 8bit
|
|
|
902636 |
|
|
|
902636 |
RH-Author: Dr. David Alan Gilbert <dgilbert@redhat.com>
|
|
|
902636 |
Message-id: <20200313171708.242774-1-dgilbert@redhat.com>
|
|
|
902636 |
Patchwork-id: 94292
|
|
|
902636 |
O-Subject: [RHEL-AV-8.2.0 qemu-kvm PATCH 1/1] exec/rom_reset: Free rom data during inmigrate skip
|
|
|
902636 |
Bugzilla: 1809380
|
|
|
902636 |
RH-Acked-by: Daniel P. Berrange <berrange@redhat.com>
|
|
|
902636 |
RH-Acked-by: Philippe Mathieu-Daudé <philmd@redhat.com>
|
|
|
902636 |
RH-Acked-by: Paolo Bonzini <pbonzini@redhat.com>
|
|
|
902636 |
|
|
|
902636 |
From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
|
|
|
902636 |
|
|
|
902636 |
bz: https://bugzilla.redhat.com/show_bug.cgi?id=1809380
|
|
|
902636 |
brew: https://brewweb.engineering.redhat.com/brew/taskinfo?taskID=27249921
|
|
|
902636 |
branch: rhel-av-8.2.0
|
|
|
902636 |
upstream: Posted and with review-by, not merged yet
|
|
|
902636 |
|
|
|
902636 |
Commit 355477f8c73e9 skips rom reset when we're an incoming migration
|
|
|
902636 |
so as not to overwrite shared ram in the ignore-shared migration
|
|
|
902636 |
optimisation.
|
|
|
902636 |
However, it's got an unexpected side effect that because it skips
|
|
|
902636 |
freeing the ROM data, when rom_reset gets called later on, after
|
|
|
902636 |
migration (e.g. during a reboot), the ROM does get reset to the original
|
|
|
902636 |
file contents. Because of seabios/x86's weird reboot process
|
|
|
902636 |
this confuses a reboot into hanging after a migration.
|
|
|
902636 |
|
|
|
902636 |
Fixes: 355477f8c73e9 ("migration: do not rom_reset() during incoming migration")
|
|
|
902636 |
https://bugzilla.redhat.com/show_bug.cgi?id=1809380
|
|
|
902636 |
|
|
|
902636 |
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
|
|
|
902636 |
Signed-off-by: Danilo C. L. de Paula <ddepaula@redhat.com>
|
|
|
902636 |
---
|
|
|
902636 |
hw/core/loader.c | 25 ++++++++++++++++---------
|
|
|
902636 |
1 file changed, 16 insertions(+), 9 deletions(-)
|
|
|
902636 |
|
|
|
902636 |
diff --git a/hw/core/loader.c b/hw/core/loader.c
|
|
|
902636 |
index 5099f27..375b29b 100644
|
|
|
902636 |
--- a/hw/core/loader.c
|
|
|
902636 |
+++ b/hw/core/loader.c
|
|
|
902636 |
@@ -1118,19 +1118,26 @@ static void rom_reset(void *unused)
|
|
|
902636 |
{
|
|
|
902636 |
Rom *rom;
|
|
|
902636 |
|
|
|
902636 |
- /*
|
|
|
902636 |
- * We don't need to fill in the RAM with ROM data because we'll fill
|
|
|
902636 |
- * the data in during the next incoming migration in all cases. Note
|
|
|
902636 |
- * that some of those RAMs can actually be modified by the guest on ARM
|
|
|
902636 |
- * so this is probably the only right thing to do here.
|
|
|
902636 |
- */
|
|
|
902636 |
- if (runstate_check(RUN_STATE_INMIGRATE))
|
|
|
902636 |
- return;
|
|
|
902636 |
-
|
|
|
902636 |
QTAILQ_FOREACH(rom, &roms, next) {
|
|
|
902636 |
if (rom->fw_file) {
|
|
|
902636 |
continue;
|
|
|
902636 |
}
|
|
|
902636 |
+ /*
|
|
|
902636 |
+ * We don't need to fill in the RAM with ROM data because we'll fill
|
|
|
902636 |
+ * the data in during the next incoming migration in all cases. Note
|
|
|
902636 |
+ * that some of those RAMs can actually be modified by the guest.
|
|
|
902636 |
+ */
|
|
|
902636 |
+ if (runstate_check(RUN_STATE_INMIGRATE)) {
|
|
|
902636 |
+ if (rom->data && rom->isrom) {
|
|
|
902636 |
+ /*
|
|
|
902636 |
+ * Free it so that a rom_reset after migration doesn't
|
|
|
902636 |
+ * overwrite a potentially modified 'rom'.
|
|
|
902636 |
+ */
|
|
|
902636 |
+ rom_free_data(rom);
|
|
|
902636 |
+ }
|
|
|
902636 |
+ continue;
|
|
|
902636 |
+ }
|
|
|
902636 |
+
|
|
|
902636 |
if (rom->data == NULL) {
|
|
|
902636 |
continue;
|
|
|
902636 |
}
|
|
|
902636 |
--
|
|
|
902636 |
1.8.3.1
|
|
|
902636 |
|