|
 |
9ae3a8 |
From 4cdc106eb2e23157acc594b8318a96803df408d0 Mon Sep 17 00:00:00 2001
|
|
|
9ae3a8 |
From: Markus Armbruster <armbru@redhat.com>
|
|
|
9ae3a8 |
Date: Wed, 18 Sep 2013 09:31:02 +0200
|
|
|
9ae3a8 |
Subject: [PATCH 18/29] exec: Fix Xen RAM allocation with unusual options
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
RH-Author: Markus Armbruster <armbru@redhat.com>
|
|
|
9ae3a8 |
Message-id: <1379496669-22778-2-git-send-email-armbru@redhat.com>
|
|
|
9ae3a8 |
Patchwork-id: 54420
|
|
|
9ae3a8 |
O-Subject: [PATCH 7.0 qemu-kvm 1/8] exec: Fix Xen RAM allocation with unusual options
|
|
|
9ae3a8 |
Bugzilla: 1009328
|
|
|
9ae3a8 |
RH-Acked-by: Paolo Bonzini <pbonzini@redhat.com>
|
|
|
9ae3a8 |
RH-Acked-by: Laszlo Ersek <lersek@redhat.com>
|
|
|
9ae3a8 |
RH-Acked-by: Miroslav Rezanina <mrezanin@redhat.com>
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
From: Markus Armbruster <armbru@redhat.com>
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
Issues:
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
* We try to obey -mem-path even though it can't work with Xen.
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
* To implement -machine mem-merge, we call
|
|
|
9ae3a8 |
memory_try_enable_merging(new_block->host, size). But with Xen,
|
|
|
9ae3a8 |
new_block->host remains null. Oops.
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
Fix by separating Xen allocation from normal allocation.
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
Acked-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
|
|
|
9ae3a8 |
Signed-off-by: Markus Armbruster <armbru@redhat.com>
|
|
|
9ae3a8 |
Acked-by: Laszlo Ersek <lersek@redhat.com>
|
|
|
9ae3a8 |
Message-id: 1375276272-15988-2-git-send-email-armbru@redhat.com
|
|
|
9ae3a8 |
Signed-off-by: Anthony Liguori <anthony@codemonkey.ws>
|
|
|
9ae3a8 |
(cherry picked from commit dfeaf2abc73429171ecc5b0b26ac4e5a24c047fc)
|
|
|
9ae3a8 |
---
|
|
|
9ae3a8 |
exec.c | 20 ++++++++++++--------
|
|
|
9ae3a8 |
1 file changed, 12 insertions(+), 8 deletions(-)
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
Signed-off-by: Miroslav Rezanina <mrezanin@redhat.com>
|
|
|
9ae3a8 |
---
|
|
|
9ae3a8 |
exec.c | 20 ++++++++++++--------
|
|
|
9ae3a8 |
1 files changed, 12 insertions(+), 8 deletions(-)
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
diff --git a/exec.c b/exec.c
|
|
|
9ae3a8 |
index ee22b9b..914d066 100644
|
|
|
9ae3a8 |
--- a/exec.c
|
|
|
9ae3a8 |
+++ b/exec.c
|
|
|
9ae3a8 |
@@ -1053,6 +1053,12 @@ ram_addr_t qemu_ram_alloc_from_ptr(ram_addr_t size, void *host,
|
|
|
9ae3a8 |
if (host) {
|
|
|
9ae3a8 |
new_block->host = host;
|
|
|
9ae3a8 |
new_block->flags |= RAM_PREALLOC_MASK;
|
|
|
9ae3a8 |
+ } else if (xen_enabled()) {
|
|
|
9ae3a8 |
+ if (mem_path) {
|
|
|
9ae3a8 |
+ fprintf(stderr, "-mem-path not supported with Xen\n");
|
|
|
9ae3a8 |
+ exit(1);
|
|
|
9ae3a8 |
+ }
|
|
|
9ae3a8 |
+ xen_ram_alloc(new_block->offset, size, mr);
|
|
|
9ae3a8 |
} else {
|
|
|
9ae3a8 |
if (mem_path) {
|
|
|
9ae3a8 |
#if defined (__linux__) && !defined(TARGET_S390X)
|
|
|
9ae3a8 |
@@ -1066,9 +1072,7 @@ ram_addr_t qemu_ram_alloc_from_ptr(ram_addr_t size, void *host,
|
|
|
9ae3a8 |
exit(1);
|
|
|
9ae3a8 |
#endif
|
|
|
9ae3a8 |
} else {
|
|
|
9ae3a8 |
- if (xen_enabled()) {
|
|
|
9ae3a8 |
- xen_ram_alloc(new_block->offset, size, mr);
|
|
|
9ae3a8 |
- } else if (kvm_enabled()) {
|
|
|
9ae3a8 |
+ if (kvm_enabled()) {
|
|
|
9ae3a8 |
/* some s390/kvm configurations have special constraints */
|
|
|
9ae3a8 |
new_block->host = kvm_ram_alloc(size);
|
|
|
9ae3a8 |
} else {
|
|
|
9ae3a8 |
@@ -1146,6 +1150,8 @@ void qemu_ram_free(ram_addr_t addr)
|
|
|
9ae3a8 |
ram_list.version++;
|
|
|
9ae3a8 |
if (block->flags & RAM_PREALLOC_MASK) {
|
|
|
9ae3a8 |
;
|
|
|
9ae3a8 |
+ } else if (xen_enabled()) {
|
|
|
9ae3a8 |
+ xen_invalidate_map_cache_entry(block->host);
|
|
|
9ae3a8 |
} else if (mem_path) {
|
|
|
9ae3a8 |
#if defined (__linux__) && !defined(TARGET_S390X)
|
|
|
9ae3a8 |
if (block->fd) {
|
|
|
9ae3a8 |
@@ -1158,11 +1164,7 @@ void qemu_ram_free(ram_addr_t addr)
|
|
|
9ae3a8 |
abort();
|
|
|
9ae3a8 |
#endif
|
|
|
9ae3a8 |
} else {
|
|
|
9ae3a8 |
- if (xen_enabled()) {
|
|
|
9ae3a8 |
- xen_invalidate_map_cache_entry(block->host);
|
|
|
9ae3a8 |
- } else {
|
|
|
9ae3a8 |
- qemu_anon_ram_free(block->host, block->length);
|
|
|
9ae3a8 |
- }
|
|
|
9ae3a8 |
+ qemu_anon_ram_free(block->host, block->length);
|
|
|
9ae3a8 |
}
|
|
|
9ae3a8 |
g_free(block);
|
|
|
9ae3a8 |
break;
|
|
|
9ae3a8 |
@@ -1186,6 +1188,8 @@ void qemu_ram_remap(ram_addr_t addr, ram_addr_t length)
|
|
|
9ae3a8 |
vaddr = block->host + offset;
|
|
|
9ae3a8 |
if (block->flags & RAM_PREALLOC_MASK) {
|
|
|
9ae3a8 |
;
|
|
|
9ae3a8 |
+ } else if (xen_enabled()) {
|
|
|
9ae3a8 |
+ abort();
|
|
|
9ae3a8 |
} else {
|
|
|
9ae3a8 |
flags = MAP_FIXED;
|
|
|
9ae3a8 |
munmap(vaddr, length);
|
|
|
9ae3a8 |
--
|
|
|
9ae3a8 |
1.7.1
|
|
|
9ae3a8 |
|