|
 |
26ba25 |
From e582296e39bcca12dbfb267b3ffc511f3f64c242 Mon Sep 17 00:00:00 2001
|
|
|
26ba25 |
From: John Snow <jsnow@redhat.com>
|
|
|
26ba25 |
Date: Wed, 10 Oct 2018 20:50:58 +0100
|
|
|
26ba25 |
Subject: [PATCH 1/3] block: for jobs, do not clear user_paused until after the
|
|
|
26ba25 |
resume
|
|
|
26ba25 |
|
|
|
26ba25 |
RH-Author: John Snow <jsnow@redhat.com>
|
|
|
26ba25 |
Message-id: <20181010205100.17689-2-jsnow@redhat.com>
|
|
|
26ba25 |
Patchwork-id: 82631
|
|
|
26ba25 |
O-Subject: [RHEL8/rhel qemu-kvm PATCH 1/3] block: for jobs, do not clear user_paused until after the resume
|
|
|
26ba25 |
Bugzilla: 1635583
|
|
|
26ba25 |
RH-Acked-by: Stefan Hajnoczi <stefanha@redhat.com>
|
|
|
26ba25 |
RH-Acked-by: Max Reitz <mreitz@redhat.com>
|
|
|
26ba25 |
RH-Acked-by: Kevin Wolf <kwolf@redhat.com>
|
|
|
26ba25 |
|
|
|
26ba25 |
From: Jeff Cody <jcody@redhat.com>
|
|
|
26ba25 |
|
|
|
26ba25 |
The function job_cancel_async() will always cause an assert for blockjob
|
|
|
26ba25 |
user resume. We set job->user_paused to false, and then call
|
|
|
26ba25 |
job->driver->user_resume(). In the case of blockjobs, this is the
|
|
|
26ba25 |
block_job_user_resume() function.
|
|
|
26ba25 |
|
|
|
26ba25 |
In that function, we assert that job.user_paused is set to true.
|
|
|
26ba25 |
Unfortunately, right before calling this function, it has explicitly
|
|
|
26ba25 |
been set to false.
|
|
|
26ba25 |
|
|
|
26ba25 |
The fix is pretty simple: set job->user_paused to false only after the
|
|
|
26ba25 |
job user_resume() function has been called.
|
|
|
26ba25 |
|
|
|
26ba25 |
Reviewed-by: John Snow <jsnow@redhat.com>
|
|
|
26ba25 |
Reviewed-by: Eric Blake <eblake@redhat.com>
|
|
|
26ba25 |
Signed-off-by: Jeff Cody <jcody@redhat.com>
|
|
|
26ba25 |
Message-id: bb183b77d8f2dd6bd67b8da559a90ac1e74b2052.1534868459.git.jcody@redhat.com
|
|
|
26ba25 |
Signed-off-by: Jeff Cody <jcody@redhat.com>
|
|
|
26ba25 |
(cherry picked from commit e321c0597c7590499bacab239d7f86e257f96bcd)
|
|
|
26ba25 |
Signed-off-by: John Snow <jsnow@redhat.com>
|
|
|
26ba25 |
Signed-off-by: Danilo C. L. de Paula <ddepaula@redhat.com>
|
|
|
26ba25 |
---
|
|
|
26ba25 |
job.c | 2 +-
|
|
|
26ba25 |
1 file changed, 1 insertion(+), 1 deletion(-)
|
|
|
26ba25 |
|
|
|
26ba25 |
diff --git a/job.c b/job.c
|
|
|
26ba25 |
index 3ab8ce1..dfba4bc 100644
|
|
|
26ba25 |
--- a/job.c
|
|
|
26ba25 |
+++ b/job.c
|
|
|
26ba25 |
@@ -700,10 +700,10 @@ static void job_cancel_async(Job *job, bool force)
|
|
|
26ba25 |
{
|
|
|
26ba25 |
if (job->user_paused) {
|
|
|
26ba25 |
/* Do not call job_enter here, the caller will handle it. */
|
|
|
26ba25 |
- job->user_paused = false;
|
|
|
26ba25 |
if (job->driver->user_resume) {
|
|
|
26ba25 |
job->driver->user_resume(job);
|
|
|
26ba25 |
}
|
|
|
26ba25 |
+ job->user_paused = false;
|
|
|
26ba25 |
assert(job->pause_count > 0);
|
|
|
26ba25 |
job->pause_count--;
|
|
|
26ba25 |
}
|
|
|
26ba25 |
--
|
|
|
26ba25 |
1.8.3.1
|
|
|
26ba25 |
|