cryptospore / rpms / qemu-kvm

Forked from rpms/qemu-kvm 2 years ago
Clone
0a122b
From 2f85f6c61990fd4d46e4980128ee8ba2d3cfaa37 Mon Sep 17 00:00:00 2001
0a122b
From: Vadim Rozenfeld <vrozenfe@redhat.com>
0a122b
Date: Mon, 3 Mar 2014 12:09:14 +0100
0a122b
Subject: [PATCH 02/12] kvm: Fix uninitialized cpuid_data
0a122b
0a122b
RH-Author: Vadim Rozenfeld <vrozenfe@redhat.com>
0a122b
Message-id: <1393848564-10511-3-git-send-email-vrozenfe@redhat.com>
0a122b
Patchwork-id: 57958
0a122b
O-Subject: [RHEL-7.0 qemu-kvm v4 PATCH 02/12] kvm: Fix uninitialized cpuid_data
0a122b
Bugzilla: 1057173
0a122b
RH-Acked-by: Paolo Bonzini <pbonzini@redhat.com>
0a122b
RH-Acked-by: Igor Mammedov <imammedo@redhat.com>
0a122b
RH-Acked-by: Juan Quintela <quintela@redhat.com>
0a122b
RH-Acked-by: Eduardo Habkost <ehabkost@redhat.com>
0a122b
0a122b
From: Stefan Weil <sw@weilnetz.de>
0a122b
0a122b
This error was reported by valgrind when running qemu-system-x86_64
0a122b
with kvm:
0a122b
0a122b
==975== Conditional jump or move depends on uninitialised value(s)
0a122b
==975==    at 0x521C38: cpuid_find_entry (kvm.c:176)
0a122b
==975==    by 0x5235BA: kvm_arch_init_vcpu (kvm.c:686)
0a122b
==975==    by 0x4D5175: kvm_init_vcpu (kvm-all.c:267)
0a122b
==975==    by 0x45035B: qemu_kvm_cpu_thread_fn (cpus.c:858)
0a122b
==975==    by 0xD361E0D: start_thread (pthread_create.c:311)
0a122b
==975==    by 0xD65E9EC: clone (clone.S:113)
0a122b
==975==  Uninitialised value was created by a stack allocation
0a122b
==975==    at 0x5226E4: kvm_arch_init_vcpu (kvm.c:446)
0a122b
0a122b
Instead of adding more memset calls for parts of cpuid_data, the existing
0a122b
calls were removed and cpuid_data is now initialized completely in one
0a122b
call.
0a122b
0a122b
Signed-off-by: Stefan Weil <sw@weilnetz.de>
0a122b
Signed-off-by: Gleb Natapov <gleb@redhat.com>
0a122b
(cherry picked from commit ef4cbe14342c1f63b3c754e306218f004f4e26c4)
0a122b
---
0a122b
 target-i386/kvm.c | 9 ++-------
0a122b
 1 file changed, 2 insertions(+), 7 deletions(-)
0a122b
0a122b
Signed-off-by: Miroslav Rezanina <mrezanin@redhat.com>
0a122b
---
0a122b
 target-i386/kvm.c |    9 ++-------
0a122b
 1 files changed, 2 insertions(+), 7 deletions(-)
0a122b
0a122b
diff --git a/target-i386/kvm.c b/target-i386/kvm.c
0a122b
index c7fabd7..3a9e376 100644
0a122b
--- a/target-i386/kvm.c
0a122b
+++ b/target-i386/kvm.c
0a122b
@@ -453,11 +453,12 @@ int kvm_arch_init_vcpu(CPUState *cs)
0a122b
     uint32_t signature[3];
0a122b
     int r;
0a122b
 
0a122b
+    memset(&cpuid_data, 0, sizeof(cpuid_data));
0a122b
+
0a122b
     cpuid_i = 0;
0a122b
 
0a122b
     /* Paravirtualization CPUIDs */
0a122b
     c = &cpuid_data.entries[cpuid_i++];
0a122b
-    memset(c, 0, sizeof(*c));
0a122b
     c->function = KVM_CPUID_SIGNATURE;
0a122b
     if (!hyperv_enabled(cpu)) {
0a122b
         memcpy(signature, "KVMKVMKVM\0\0\0", 12);
0a122b
@@ -471,7 +472,6 @@ int kvm_arch_init_vcpu(CPUState *cs)
0a122b
     c->edx = signature[2];
0a122b
 
0a122b
     c = &cpuid_data.entries[cpuid_i++];
0a122b
-    memset(c, 0, sizeof(*c));
0a122b
     c->function = KVM_CPUID_FEATURES;
0a122b
     c->eax = env->features[FEAT_KVM];
0a122b
 
0a122b
@@ -480,13 +480,11 @@ int kvm_arch_init_vcpu(CPUState *cs)
0a122b
         c->eax = signature[0];
0a122b
 
0a122b
         c = &cpuid_data.entries[cpuid_i++];
0a122b
-        memset(c, 0, sizeof(*c));
0a122b
         c->function = HYPERV_CPUID_VERSION;
0a122b
         c->eax = 0x00001bbc;
0a122b
         c->ebx = 0x00060001;
0a122b
 
0a122b
         c = &cpuid_data.entries[cpuid_i++];
0a122b
-        memset(c, 0, sizeof(*c));
0a122b
         c->function = HYPERV_CPUID_FEATURES;
0a122b
         if (cpu->hyperv_relaxed_timing) {
0a122b
             c->eax |= HV_X64_MSR_HYPERCALL_AVAILABLE;
0a122b
@@ -497,7 +495,6 @@ int kvm_arch_init_vcpu(CPUState *cs)
0a122b
         }
0a122b
 
0a122b
         c = &cpuid_data.entries[cpuid_i++];
0a122b
-        memset(c, 0, sizeof(*c));
0a122b
         c->function = HYPERV_CPUID_ENLIGHTMENT_INFO;
0a122b
         if (cpu->hyperv_relaxed_timing) {
0a122b
             c->eax |= HV_X64_RELAXED_TIMING_RECOMMENDED;
0a122b
@@ -508,13 +505,11 @@ int kvm_arch_init_vcpu(CPUState *cs)
0a122b
         c->ebx = cpu->hyperv_spinlock_attempts;
0a122b
 
0a122b
         c = &cpuid_data.entries[cpuid_i++];
0a122b
-        memset(c, 0, sizeof(*c));
0a122b
         c->function = HYPERV_CPUID_IMPLEMENT_LIMITS;
0a122b
         c->eax = 0x40;
0a122b
         c->ebx = 0x40;
0a122b
 
0a122b
         c = &cpuid_data.entries[cpuid_i++];
0a122b
-        memset(c, 0, sizeof(*c));
0a122b
         c->function = KVM_CPUID_SIGNATURE_NEXT;
0a122b
         memcpy(signature, "KVMKVMKVM\0\0\0", 12);
0a122b
         c->eax = 0;
0a122b
-- 
0a122b
1.7.1
0a122b