chantra / rpms / libdnf

Forked from rpms/libdnf 2 years ago
Clone
aea1e4
From e43ef244e78d8563eb3cb7ff6a6074946f60c877 Mon Sep 17 00:00:00 2001
aea1e4
From: =?UTF-8?q?Ale=C5=A1=20Mat=C4=9Bj?= <amatej@redhat.com>
aea1e4
Date: Sun, 25 Apr 2021 19:47:53 +0200
aea1e4
Subject: [PATCH 09/19] Revert "Change mechanism of module conflicts"
aea1e4
aea1e4
This reverts commit 49600ba05b474bc29651aa122a9116b5ada69f4d.
aea1e4
---
aea1e4
 libdnf/dnf-sack.cpp                      | 1 +
aea1e4
 libdnf/module/ModulePackage.cpp          | 2 --
aea1e4
 libdnf/module/ModulePackage.hpp          | 1 -
aea1e4
 libdnf/module/ModulePackageContainer.cpp | 1 -
aea1e4
 libdnf/module/ModulePackageContainer.hpp | 1 -
aea1e4
 5 files changed, 1 insertion(+), 5 deletions(-)
aea1e4
aea1e4
diff --git a/libdnf/dnf-sack.cpp b/libdnf/dnf-sack.cpp
aea1e4
index b5c7edc0..b9baeaef 100644
aea1e4
--- a/libdnf/dnf-sack.cpp
aea1e4
+++ b/libdnf/dnf-sack.cpp
aea1e4
@@ -2297,6 +2297,7 @@ void readModuleMetadataFromRepo(DnfSack * sack, libdnf::ModulePackageContainer *
aea1e4
     modulePackages->add(sack);
aea1e4
     modulePackages->loadFailSafeData();
aea1e4
     if (!modulePackages->empty()) {
aea1e4
+        modulePackages->createConflictsBetweenStreams();
aea1e4
         // TODO remove hard-coded path
aea1e4
         try {
aea1e4
             std::vector<std::string> paths{"/etc/os-release", "/usr/lib/os-release"};
aea1e4
diff --git a/libdnf/module/ModulePackage.cpp b/libdnf/module/ModulePackage.cpp
aea1e4
index d0017877..d644eca6 100644
aea1e4
--- a/libdnf/module/ModulePackage.cpp
aea1e4
+++ b/libdnf/module/ModulePackage.cpp
aea1e4
@@ -75,8 +75,6 @@ static void setSovable(Pool * pool, Solvable * solvable, const std::string & nam
aea1e4
     ss << "module(" << name << ")";
aea1e4
     auto depId = pool_str2id(pool, ss.str().c_str(), 1);
aea1e4
     solvable_add_deparray(solvable, SOLVABLE_PROVIDES, depId, -1);
aea1e4
-    // create Conflicts: module($name)
aea1e4
-    solvable_add_deparray(solvable, SOLVABLE_CONFLICTS, depId, 0);
aea1e4
 
aea1e4
     // create Provide: module($name:$stream)
aea1e4
     ss.str(std::string());
aea1e4
diff --git a/libdnf/module/ModulePackage.hpp b/libdnf/module/ModulePackage.hpp
aea1e4
index b618df58..145c6d63 100644
aea1e4
--- a/libdnf/module/ModulePackage.hpp
aea1e4
+++ b/libdnf/module/ModulePackage.hpp
aea1e4
@@ -71,7 +71,6 @@ public:
aea1e4
 
aea1e4
     std::vector<ModuleDependencies> getModuleDependencies() const;
aea1e4
 
aea1e4
-    ///DEPRECATED
aea1e4
     void addStreamConflict(const ModulePackage * package);
aea1e4
 
aea1e4
     Id getId() const { return id; };
aea1e4
diff --git a/libdnf/module/ModulePackageContainer.cpp b/libdnf/module/ModulePackageContainer.cpp
aea1e4
index 97c84c01..893b839a 100644
aea1e4
--- a/libdnf/module/ModulePackageContainer.cpp
aea1e4
+++ b/libdnf/module/ModulePackageContainer.cpp
aea1e4
@@ -204,7 +204,6 @@ private:
aea1e4
     /// solvable.arch = <moduleArch>
aea1e4
     /// solvable.summary = <moduleContext>
aea1e4
     /// solvable.description = <moduleName>:<moduleStream>
aea1e4
-    /// solvable.conflicts = module(<moduleName>)
aea1e4
     DnfSack * moduleSack;
aea1e4
     std::unique_ptr<PackageSet> activatedModules;
aea1e4
     std::string installRoot;
aea1e4
diff --git a/libdnf/module/ModulePackageContainer.hpp b/libdnf/module/ModulePackageContainer.hpp
aea1e4
index 99fc0677..c1001fce 100644
aea1e4
--- a/libdnf/module/ModulePackageContainer.hpp
aea1e4
+++ b/libdnf/module/ModulePackageContainer.hpp
aea1e4
@@ -115,7 +115,6 @@ public:
aea1e4
     Id addPlatformPackage(const std::string &osReleasePath, const char *  platformModule);
aea1e4
     Id addPlatformPackage(DnfSack * sack,
aea1e4
         const std::vector<std::string> & osReleasePath, const char * platformModule);
aea1e4
-    /// DEPRECATED
aea1e4
     void createConflictsBetweenStreams();
aea1e4
 
aea1e4
     /**
aea1e4
-- 
aea1e4
2.31.1
aea1e4