areguera / rpms / mailman

Forked from rpms/mailman 4 years ago
Clone

Blame SOURCES/mailman-2_1-xss_vulnerability.patch

49da8b
diff --git a/Mailman/Cgi/options.py b/Mailman/Cgi/options.py
49da8b
index 9a2389a..ae701a7 100644
49da8b
--- a/Mailman/Cgi/options.py
49da8b
+++ b/Mailman/Cgi/options.py
49da8b
@@ -18,6 +18,7 @@
49da8b
 """Produce and handle the member options."""
49da8b
 
49da8b
 import sys
49da8b
+import re
49da8b
 import os
49da8b
 import cgi
49da8b
 import signal
49da8b
@@ -149,19 +150,6 @@ def main():
49da8b
     doc.set_language(userlang)
49da8b
     i18n.set_language(userlang)
49da8b
 
49da8b
-    # See if this is VARHELP on topics.
49da8b
-    varhelp = None
49da8b
-    if cgidata.has_key('VARHELP'):
49da8b
-        varhelp = cgidata['VARHELP'].value
49da8b
-    elif os.environ.get('QUERY_STRING'):
49da8b
-        # POST methods, even if their actions have a query string, don't get
49da8b
-        # put into FieldStorage's keys :-(
49da8b
-        qs = cgi.parse_qs(os.environ['QUERY_STRING']).get('VARHELP')
49da8b
-        if qs and type(qs) == types.ListType:
49da8b
-            varhelp = qs[0]
49da8b
-    if varhelp:
49da8b
-        topic_details(mlist, doc, user, cpuser, userlang, varhelp)
49da8b
-        return
49da8b
 
49da8b
     # Are we processing an unsubscription request from the login screen?
49da8b
     if cgidata.has_key('login-unsub'):
49da8b
@@ -261,6 +249,22 @@ def main():
49da8b
         print doc.Format()
49da8b
         return
49da8b
 
49da8b
+    # See if this is VARHELP on topics.
49da8b
+    varhelp = None
49da8b
+    if cgidata.has_key('VARHELP'):
49da8b
+        varhelp = cgidata['VARHELP'].value
49da8b
+    elif os.environ.get('QUERY_STRING'):
49da8b
+        # POST methods, even if their actions have a query string, don't get
49da8b
+        # put into FieldStorage's keys :-(
49da8b
+        qs = cgi.parse_qs(os.environ['QUERY_STRING']).get('VARHELP')
49da8b
+        if qs and type(qs) == types.ListType:
49da8b
+            varhelp = qs[0]
49da8b
+    if varhelp:
49da8b
+        # Sanitize the topic name.
49da8b
+        varhelp = re.sub('<.*', '', varhelp)
49da8b
+        topic_details(mlist, doc, user, cpuser, userlang, varhelp)
49da8b
+        return
49da8b
+
49da8b
     # From here on out, the user is okay to view and modify their membership
49da8b
     # options.  The first set of checks does not require the list to be
49da8b
     # locked.