anitazha / rpms / systemd

Forked from rpms/systemd 3 years ago
Clone

Blame SOURCES/0751-core-rerun-GC-logic-for-a-unit-that-loses-a-referenc.patch

661545
From 0ace07115f14a57c81afbc9a7e947778a743870e Mon Sep 17 00:00:00 2001
9ab0c5
From: Lennart Poettering <lennart@poettering.net>
9ab0c5
Date: Fri, 29 Apr 2016 11:18:53 +0200
9ab0c5
Subject: [PATCH] core: rerun GC logic for a unit that loses a reference
9ab0c5
9ab0c5
Let's make sure when we drop a reference to a unit, that we run the GC queue on
9ab0c5
it again.
9ab0c5
9ab0c5
This (together with the previous commit) should deal with the GC issues pointed
9ab0c5
out in:
9ab0c5
9ab0c5
https://github.com/systemd/systemd/pull/2993#issuecomment-215331189
9ab0c5
(cherry picked from commit b75102e5bf4cf249052d42be955d403e3e03b47c)
9ab0c5
661545
Related: #1718953
9ab0c5
---
9ab0c5
 src/core/unit.c | 4 ++++
9ab0c5
 1 file changed, 4 insertions(+)
9ab0c5
9ab0c5
diff --git a/src/core/unit.c b/src/core/unit.c
9ab0c5
index 1dff541ac3..b004aa8fcd 100644
9ab0c5
--- a/src/core/unit.c
9ab0c5
+++ b/src/core/unit.c
9ab0c5
@@ -3145,6 +3145,10 @@ void unit_ref_unset(UnitRef *ref) {
9ab0c5
         if (!ref->unit)
9ab0c5
                 return;
9ab0c5
 
9ab0c5
+        /* We are about to drop a reference to the unit, make sure the garbage collection has a look at it as it might
9ab0c5
+         * be unreferenced now. */
9ab0c5
+        unit_add_to_gc_queue(ref->unit);
9ab0c5
+
9ab0c5
         LIST_REMOVE(refs, ref->unit->refs, ref);
9ab0c5
         ref->unit = NULL;
9ab0c5
 }