|
 |
803fb7 |
From 9d00fbb87c43e129e1ab29298afc86b7e8eed25c Mon Sep 17 00:00:00 2001
|
|
|
803fb7 |
From: Evgeny Vereshchagin <evvers@ya.ru>
|
|
|
803fb7 |
Date: Mon, 18 Jan 2016 06:10:33 +0000
|
|
|
803fb7 |
Subject: [PATCH] core: fix memory leak on failed preset-all
|
|
|
803fb7 |
|
|
|
803fb7 |
How to reproduce
|
|
|
803fb7 |
$ systemctl set-default multi-user # https://github.com/systemd/systemd/issues/2298
|
|
|
803fb7 |
$ systemctl preset-all
|
|
|
803fb7 |
Failed to execute operation: Too many levels of symbolic links
|
|
|
803fb7 |
|
|
|
803fb7 |
$ systemctl poweroff
|
|
|
803fb7 |
|
|
|
803fb7 |
Fixes:
|
|
|
803fb7 |
==1==
|
|
|
803fb7 |
==1== HEAP SUMMARY:
|
|
|
803fb7 |
==1== in use at exit: 65,645 bytes in 7 blocks
|
|
|
803fb7 |
==1== total heap usage: 40,539 allocs, 40,532 frees, 30,147,547 bytes allocated
|
|
|
803fb7 |
==1==
|
|
|
803fb7 |
==1== 109 (24 direct, 85 indirect) bytes in 1 blocks are definitely lost in loss record 2 of 7
|
|
|
803fb7 |
==1== at 0x4C2BBCF: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
|
|
|
803fb7 |
==1== by 0x4C2DE2F: realloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
|
|
|
803fb7 |
==1== by 0x23DA71: unit_file_changes_add (install.c:233)
|
|
|
803fb7 |
==1== by 0x23E45D: remove_marked_symlinks_fd (install.c:453)
|
|
|
803fb7 |
==1== by 0x23E267: remove_marked_symlinks_fd (install.c:405)
|
|
|
803fb7 |
==1== by 0x23E641: remove_marked_symlinks (install.c:494)
|
|
|
803fb7 |
==1== by 0x243A91: execute_preset (install.c:2190)
|
|
|
803fb7 |
==1== by 0x244343: unit_file_preset_all (install.c:2351)
|
|
|
803fb7 |
==1== by 0x18AAA2: method_preset_all_unit_files (dbus-manager.c:1846)
|
|
|
803fb7 |
==1== by 0x1D8157: method_callbacks_run (bus-objects.c:420)
|
|
|
803fb7 |
==1== by 0x1DA9E9: object_find_and_run (bus-objects.c:1257)
|
|
|
803fb7 |
==1== by 0x1DB02B: bus_process_object (bus-objects.c:1373)
|
|
|
803fb7 |
==1==
|
|
|
803fb7 |
==1== LEAK SUMMARY:
|
|
|
803fb7 |
==1== definitely lost: 24 bytes in 1 blocks
|
|
|
803fb7 |
==1== indirectly lost: 85 bytes in 1 blocks
|
|
|
803fb7 |
==1== possibly lost: 0 bytes in 0 blocks
|
|
|
803fb7 |
==1== still reachable: 65,536 bytes in 5 blocks
|
|
|
803fb7 |
==1== suppressed: 0 bytes in 0 blocks
|
|
|
803fb7 |
==1== Reachable blocks (those to which a pointer was found) are not shown.
|
|
|
803fb7 |
==1== To see them, rerun with: --leak-check=full --show-leak-kinds=all
|
|
|
803fb7 |
==1==
|
|
|
803fb7 |
==1== For counts of detected and suppressed errors, rerun with: -v
|
|
|
803fb7 |
==1== ERROR SUMMARY: 1 errors from 1 contexts (suppressed: 0 from 0)
|
|
|
803fb7 |
|
|
|
803fb7 |
Cherry-picked from: c292c3af38c8c23e183f3e63ef492926cea64bab
|
|
|
803fb7 |
Related: #1331667
|
|
|
803fb7 |
---
|
|
|
803fb7 |
src/core/dbus-manager.c | 4 +++-
|
|
|
803fb7 |
1 file changed, 3 insertions(+), 1 deletion(-)
|
|
|
803fb7 |
|
|
|
803fb7 |
diff --git a/src/core/dbus-manager.c b/src/core/dbus-manager.c
|
|
|
803fb7 |
index 1a5525e50..9eef290ca 100644
|
|
|
803fb7 |
--- a/src/core/dbus-manager.c
|
|
|
803fb7 |
+++ b/src/core/dbus-manager.c
|
|
|
803fb7 |
@@ -1875,8 +1875,10 @@ static int method_preset_all_unit_files(sd_bus *bus, sd_bus_message *message, vo
|
|
|
803fb7 |
scope = m->running_as == SYSTEMD_SYSTEM ? UNIT_FILE_SYSTEM : UNIT_FILE_USER;
|
|
|
803fb7 |
|
|
|
803fb7 |
r = unit_file_preset_all(scope, runtime, NULL, mm, force, &changes, &n_changes);
|
|
|
803fb7 |
- if (r < 0)
|
|
|
803fb7 |
+ if (r < 0) {
|
|
|
803fb7 |
+ unit_file_changes_free(changes, n_changes);
|
|
|
803fb7 |
return r;
|
|
|
803fb7 |
+ }
|
|
|
803fb7 |
|
|
|
803fb7 |
return reply_unit_file_changes_and_free(m, bus, message, -1, changes, n_changes);
|
|
|
803fb7 |
}
|