anitazha / rpms / ndctl

Forked from rpms/ndctl 2 years ago
Clone

Blame SOURCES/0212-scripts-update-release-helper-scripts-for-meson-and-.patch

e0018b
From 9ce0fa95778a76d2334848e2629d111c4d636515 Mon Sep 17 00:00:00 2001
e0018b
From: Vishal Verma <vishal.l.verma@intel.com>
e0018b
Date: Wed, 15 Jun 2022 16:48:13 -0600
e0018b
Subject: [PATCH 212/217] scripts: update release helper scripts for meson and
e0018b
 cxl
e0018b
e0018b
The prepare-release.sh and do_abidiff scripts perform sanity checking
e0018b
for library versioning and also guard against accidental ABI breakage
e0018b
by comparing the current release with the previous using 'abipkgdiff'
e0018b
from libabigail. Teach the scripts about libcxl, so that it too can
e0018b
participate in the above checks.
e0018b
e0018b
Additionally, move the checks over to the new meson regime. This does
e0018b
break any checking for the older autotools based build, but that should
e0018b
be okay.
e0018b
e0018b
Link: https://lore.kernel.org/r/20220615224813.523053-6-vishal.l.verma@intel.com
e0018b
Cc: Dan Williams <dan.j.williams@intel.com>
e0018b
Signed-off-by: Vishal Verma <vishal.l.verma@intel.com>
e0018b
---
e0018b
 scripts/do_abidiff         | 3 ++-
e0018b
 scripts/prepare-release.sh | 3 ++-
e0018b
 2 files changed, 4 insertions(+), 2 deletions(-)
e0018b
e0018b
diff --git a/scripts/do_abidiff b/scripts/do_abidiff
e0018b
index e8c3a65..ec3e344 100755
e0018b
--- a/scripts/do_abidiff
e0018b
+++ b/scripts/do_abidiff
e0018b
@@ -53,7 +53,7 @@ do_diff()
e0018b
 	local old_lib="$(find . -regex "./release/rel_${old}/${pkg}-libs-[0-9]+.*" | head -1)"
e0018b
 	local new_lib="$(find . -regex "./release/rel_${new}/${pkg}-libs-[0-9]+.*" | head -1)"
e0018b
 
e0018b
-	[ -n "$pkg" ] || err "specify a package for diff (ndctl, daxctl)"
e0018b
+	[ -n "$pkg" ] || err "specify a package for diff (ndctl, daxctl, cxl)"
e0018b
 	[ -n "$old_base" ] || err "$pkg: old_base empty, possible build failure"
e0018b
 	[ -n "$new_base" ] || err "$pkg: new_base empty, possible build failure"
e0018b
 
e0018b
@@ -75,3 +75,4 @@ build_rpm $old > release/buildlog_$old 2>&1
e0018b
 build_rpm $new > release/buildlog_$new 2>&1
e0018b
 do_diff ndctl
e0018b
 do_diff daxctl
e0018b
+do_diff cxl
e0018b
diff --git a/scripts/prepare-release.sh b/scripts/prepare-release.sh
e0018b
index 97ab964..8901b50 100755
e0018b
--- a/scripts/prepare-release.sh
e0018b
+++ b/scripts/prepare-release.sh
e0018b
@@ -100,7 +100,7 @@ gen_lists()
e0018b
 }
e0018b
 
e0018b
 # Check libtool versions in Makefile.am.in
e0018b
-# $1: lib name (currently libndctl or libdaxctl)
e0018b
+# $1: lib name (currently libndctl, libdaxctl, or libcxl)
e0018b
 check_libtool_vers()
e0018b
 {
e0018b
 	local lib="$1"
e0018b
@@ -181,6 +181,7 @@ next_fix=$(next_fix "$last_fix")
e0018b
 
e0018b
 check_libtool_vers "libndctl"
e0018b
 check_libtool_vers "libdaxctl"
e0018b
+check_libtool_vers "libcxl"
e0018b
 
e0018b
 # HEAD~1 because HEAD would be the release commit
e0018b
 gen_lists ${last_ref}..HEAD~1
e0018b
-- 
e0018b
2.27.0
e0018b