|
Jeff Moyer |
2c91dc |
From 9ce0fa95778a76d2334848e2629d111c4d636515 Mon Sep 17 00:00:00 2001
|
|
Jeff Moyer |
2c91dc |
From: Vishal Verma <vishal.l.verma@intel.com>
|
|
Jeff Moyer |
2c91dc |
Date: Wed, 15 Jun 2022 16:48:13 -0600
|
|
Jeff Moyer |
2c91dc |
Subject: [PATCH 212/217] scripts: update release helper scripts for meson and
|
|
Jeff Moyer |
2c91dc |
cxl
|
|
Jeff Moyer |
2c91dc |
|
|
Jeff Moyer |
2c91dc |
The prepare-release.sh and do_abidiff scripts perform sanity checking
|
|
Jeff Moyer |
2c91dc |
for library versioning and also guard against accidental ABI breakage
|
|
Jeff Moyer |
2c91dc |
by comparing the current release with the previous using 'abipkgdiff'
|
|
Jeff Moyer |
2c91dc |
from libabigail. Teach the scripts about libcxl, so that it too can
|
|
Jeff Moyer |
2c91dc |
participate in the above checks.
|
|
Jeff Moyer |
2c91dc |
|
|
Jeff Moyer |
2c91dc |
Additionally, move the checks over to the new meson regime. This does
|
|
Jeff Moyer |
2c91dc |
break any checking for the older autotools based build, but that should
|
|
Jeff Moyer |
2c91dc |
be okay.
|
|
Jeff Moyer |
2c91dc |
|
|
Jeff Moyer |
2c91dc |
Link: https://lore.kernel.org/r/20220615224813.523053-6-vishal.l.verma@intel.com
|
|
Jeff Moyer |
2c91dc |
Cc: Dan Williams <dan.j.williams@intel.com>
|
|
Jeff Moyer |
2c91dc |
Signed-off-by: Vishal Verma <vishal.l.verma@intel.com>
|
|
Jeff Moyer |
2c91dc |
---
|
|
Jeff Moyer |
2c91dc |
scripts/do_abidiff | 3 ++-
|
|
Jeff Moyer |
2c91dc |
scripts/prepare-release.sh | 3 ++-
|
|
Jeff Moyer |
2c91dc |
2 files changed, 4 insertions(+), 2 deletions(-)
|
|
Jeff Moyer |
2c91dc |
|
|
Jeff Moyer |
2c91dc |
diff --git a/scripts/do_abidiff b/scripts/do_abidiff
|
|
Jeff Moyer |
2c91dc |
index e8c3a65..ec3e344 100755
|
|
Jeff Moyer |
2c91dc |
--- a/scripts/do_abidiff
|
|
Jeff Moyer |
2c91dc |
+++ b/scripts/do_abidiff
|
|
Jeff Moyer |
2c91dc |
@@ -53,7 +53,7 @@ do_diff()
|
|
Jeff Moyer |
2c91dc |
local old_lib="$(find . -regex "./release/rel_${old}/${pkg}-libs-[0-9]+.*" | head -1)"
|
|
Jeff Moyer |
2c91dc |
local new_lib="$(find . -regex "./release/rel_${new}/${pkg}-libs-[0-9]+.*" | head -1)"
|
|
Jeff Moyer |
2c91dc |
|
|
Jeff Moyer |
2c91dc |
- [ -n "$pkg" ] || err "specify a package for diff (ndctl, daxctl)"
|
|
Jeff Moyer |
2c91dc |
+ [ -n "$pkg" ] || err "specify a package for diff (ndctl, daxctl, cxl)"
|
|
Jeff Moyer |
2c91dc |
[ -n "$old_base" ] || err "$pkg: old_base empty, possible build failure"
|
|
Jeff Moyer |
2c91dc |
[ -n "$new_base" ] || err "$pkg: new_base empty, possible build failure"
|
|
Jeff Moyer |
2c91dc |
|
|
Jeff Moyer |
2c91dc |
@@ -75,3 +75,4 @@ build_rpm $old > release/buildlog_$old 2>&1
|
|
Jeff Moyer |
2c91dc |
build_rpm $new > release/buildlog_$new 2>&1
|
|
Jeff Moyer |
2c91dc |
do_diff ndctl
|
|
Jeff Moyer |
2c91dc |
do_diff daxctl
|
|
Jeff Moyer |
2c91dc |
+do_diff cxl
|
|
Jeff Moyer |
2c91dc |
diff --git a/scripts/prepare-release.sh b/scripts/prepare-release.sh
|
|
Jeff Moyer |
2c91dc |
index 97ab964..8901b50 100755
|
|
Jeff Moyer |
2c91dc |
--- a/scripts/prepare-release.sh
|
|
Jeff Moyer |
2c91dc |
+++ b/scripts/prepare-release.sh
|
|
Jeff Moyer |
2c91dc |
@@ -100,7 +100,7 @@ gen_lists()
|
|
Jeff Moyer |
2c91dc |
}
|
|
Jeff Moyer |
2c91dc |
|
|
Jeff Moyer |
2c91dc |
# Check libtool versions in Makefile.am.in
|
|
Jeff Moyer |
2c91dc |
-# $1: lib name (currently libndctl or libdaxctl)
|
|
Jeff Moyer |
2c91dc |
+# $1: lib name (currently libndctl, libdaxctl, or libcxl)
|
|
Jeff Moyer |
2c91dc |
check_libtool_vers()
|
|
Jeff Moyer |
2c91dc |
{
|
|
Jeff Moyer |
2c91dc |
local lib="$1"
|
|
Jeff Moyer |
2c91dc |
@@ -181,6 +181,7 @@ next_fix=$(next_fix "$last_fix")
|
|
Jeff Moyer |
2c91dc |
|
|
Jeff Moyer |
2c91dc |
check_libtool_vers "libndctl"
|
|
Jeff Moyer |
2c91dc |
check_libtool_vers "libdaxctl"
|
|
Jeff Moyer |
2c91dc |
+check_libtool_vers "libcxl"
|
|
Jeff Moyer |
2c91dc |
|
|
Jeff Moyer |
2c91dc |
# HEAD~1 because HEAD would be the release commit
|
|
Jeff Moyer |
2c91dc |
gen_lists ${last_ref}..HEAD~1
|
|
Jeff Moyer |
2c91dc |
--
|
|
Jeff Moyer |
2c91dc |
2.27.0
|
|
Jeff Moyer |
2c91dc |
|