Blame 0146-cxl-list-always-free-the-path-var-in-add_cxl_decoder.patch
|
Jeff Moyer |
2c91dc |
From 7564aeeae7bc8c3813bd80676769bd11a1055ca0 Mon Sep 17 00:00:00 2001
|
|
Jeff Moyer |
2c91dc |
From: Alison Schofield <alison.schofield@intel.com>
|
|
Jeff Moyer |
2c91dc |
Date: Thu, 3 Mar 2022 17:36:43 -0800
|
|
Jeff Moyer |
2c91dc |
Subject: [PATCH 146/217] cxl/list: always free the path var in
|
|
Jeff Moyer |
2c91dc |
add_cxl_decoder()
|
|
Jeff Moyer |
2c91dc |
|
|
Jeff Moyer |
2c91dc |
Static analysis reported a resource leak where the 'path' variable was
|
|
Jeff Moyer |
2c91dc |
not always freed before returns.
|
|
Jeff Moyer |
2c91dc |
|
|
Jeff Moyer |
2c91dc |
Link: https://lore.kernel.org/r/20220304013643.1054605-1-alison.schofield@intel.com
|
|
Jeff Moyer |
2c91dc |
Fixes: 46564977afb7 ("cxl/list: Add decoder support")
|
|
Jeff Moyer |
2c91dc |
Signed-off-by: Alison Schofield <alison.schofield@intel.com>
|
|
Jeff Moyer |
2c91dc |
Signed-off-by: Vishal Verma <vishal.l.verma@intel.com>
|
|
Jeff Moyer |
2c91dc |
---
|
|
Jeff Moyer |
2c91dc |
cxl/lib/libcxl.c | 2 ++
|
|
Jeff Moyer |
2c91dc |
1 file changed, 2 insertions(+)
|
|
Jeff Moyer |
2c91dc |
|
|
Jeff Moyer |
2c91dc |
diff --git a/cxl/lib/libcxl.c b/cxl/lib/libcxl.c
|
|
Jeff Moyer |
2c91dc |
index 1782f42..59e1644 100644
|
|
Jeff Moyer |
2c91dc |
--- a/cxl/lib/libcxl.c
|
|
Jeff Moyer |
2c91dc |
+++ b/cxl/lib/libcxl.c
|
|
Jeff Moyer |
2c91dc |
@@ -1018,11 +1018,13 @@ static void *add_cxl_decoder(void *parent, int id, const char *cxldecoder_base)
|
|
Jeff Moyer |
2c91dc |
cxl_decoder_foreach(port, decoder_dup)
|
|
Jeff Moyer |
2c91dc |
if (decoder_dup->id == decoder->id) {
|
|
Jeff Moyer |
2c91dc |
free_decoder(decoder, NULL);
|
|
Jeff Moyer |
2c91dc |
+ free(path);
|
|
Jeff Moyer |
2c91dc |
return decoder_dup;
|
|
Jeff Moyer |
2c91dc |
}
|
|
Jeff Moyer |
2c91dc |
|
|
Jeff Moyer |
2c91dc |
list_add(&port->decoders, &decoder->list);
|
|
Jeff Moyer |
2c91dc |
|
|
Jeff Moyer |
2c91dc |
+ free(path);
|
|
Jeff Moyer |
2c91dc |
return decoder;
|
|
Jeff Moyer |
2c91dc |
|
|
Jeff Moyer |
2c91dc |
err_decoder:
|
|
Jeff Moyer |
2c91dc |
--
|
|
Jeff Moyer |
2c91dc |
2.27.0
|
|
Jeff Moyer |
2c91dc |
|