anitazha / rpms / ndctl

Forked from rpms/ndctl 2 years ago
Clone

Blame 0142-util-size.h-Fix-build-error-for-GCC-10.patch

Jeff Moyer 2c91dc
From 3b5fb8b6428dfaab39bab58d67412427f514c1f4 Mon Sep 17 00:00:00 2001
Jeff Moyer 2c91dc
From: Vaibhav Jain <vaibhav@linux.ibm.com>
Jeff Moyer 2c91dc
Date: Sat, 26 Feb 2022 17:09:55 +0530
Jeff Moyer 2c91dc
Subject: [PATCH 142/217] util/size.h: Fix build error for GCC < 10
Jeff Moyer 2c91dc
Jeff Moyer 2c91dc
Building with GCC 8.4.1 results in following build error for 'util/size.c':
Jeff Moyer 2c91dc
Jeff Moyer 2c91dc
../util/size.h:57:16: error: missing binary operator before token "("
Jeff Moyer 2c91dc
   __has_builtin(__builtin_mul_overflow) && \
Jeff Moyer 2c91dc
Jeff Moyer 2c91dc
This is caused due to missing '__has_builtin' preprocessor operator in GCC
Jeff Moyer 2c91dc
versions < 10.0.0. The patch updates the check for CLANG's availability of
Jeff Moyer 2c91dc
__builtin_{mul,add}_overflow to prevent preprocessor from evaluating the
Jeff Moyer 2c91dc
expression "___has_builtin(__builtin_mul_overflow) &&
Jeff Moyer 2c91dc
__has_builtin(__builtin_add_overflow)".
Jeff Moyer 2c91dc
Jeff Moyer 2c91dc
Link: https://lore.kernel.org/r/20220226113955.526036-1-vaibhav@linux.ibm.com
Jeff Moyer 2c91dc
Fixes:10653a171bc0("util/size.h: fix build for older compilers")
Jeff Moyer 2c91dc
Reported-by: Tarun Sahu <tsahu@linux.ibm.com>
Jeff Moyer 2c91dc
Reviewed-by: Joao Martins <joao.m.martins@oracle.com>
Jeff Moyer 2c91dc
Signed-off-by: Vaibhav Jain <vaibhav@linux.ibm.com>
Jeff Moyer 2c91dc
Signed-off-by: Vishal Verma <vishal.l.verma@intel.com>
Jeff Moyer 2c91dc
---
Jeff Moyer 2c91dc
 util/size.h | 5 +++--
Jeff Moyer 2c91dc
 1 file changed, 3 insertions(+), 2 deletions(-)
Jeff Moyer 2c91dc
Jeff Moyer 2c91dc
diff --git a/util/size.h b/util/size.h
Jeff Moyer 2c91dc
index 1cb0669..02baa77 100644
Jeff Moyer 2c91dc
--- a/util/size.h
Jeff Moyer 2c91dc
+++ b/util/size.h
Jeff Moyer 2c91dc
@@ -53,11 +53,12 @@ static inline bool is_power_of_2(unsigned long long v)
Jeff Moyer 2c91dc
 #define COMPILER_HAS_GENERIC_BUILTIN_OVERFLOW 1
Jeff Moyer 2c91dc
 #endif
Jeff Moyer 2c91dc
 
Jeff Moyer 2c91dc
-#if __clang__ && \
Jeff Moyer 2c91dc
-    __has_builtin(__builtin_mul_overflow) && \
Jeff Moyer 2c91dc
+#if __clang__
Jeff Moyer 2c91dc
+#if __has_builtin(__builtin_mul_overflow) && \
Jeff Moyer 2c91dc
     __has_builtin(__builtin_add_overflow)
Jeff Moyer 2c91dc
 #define COMPILER_HAS_GENERIC_BUILTIN_OVERFLOW 1
Jeff Moyer 2c91dc
 #endif
Jeff Moyer 2c91dc
+#endif
Jeff Moyer 2c91dc
 
Jeff Moyer 2c91dc
 #if COMPILER_HAS_GENERIC_BUILTIN_OVERFLOW
Jeff Moyer 2c91dc
 
Jeff Moyer 2c91dc
-- 
Jeff Moyer 2c91dc
2.27.0
Jeff Moyer 2c91dc