|
 |
74ca47 |
From 70230bf894d9c0150dca8dc6fccc2712187f7b86 Mon Sep 17 00:00:00 2001
|
|
|
74ca47 |
From: William Brown <firstyear@redhat.com>
|
|
|
74ca47 |
Date: Mon, 13 Mar 2017 13:29:43 +1000
|
|
|
74ca47 |
Subject: [PATCH 1/5] Ticket 49164 - Change NS to acq-rel semantics for atomics
|
|
|
74ca47 |
|
|
|
74ca47 |
Bug Description: We were using seq_cst to guarantee our operations
|
|
|
74ca47 |
as a poc. Changing to acq/rel allows us the same guarantees, but
|
|
|
74ca47 |
with less overheads.
|
|
|
74ca47 |
|
|
|
74ca47 |
Fix Description: Change the barrier type.
|
|
|
74ca47 |
|
|
|
74ca47 |
https://gcc.gnu.org/wiki/Atomic/GCCMM/AtomicSync
|
|
|
74ca47 |
|
|
|
74ca47 |
https://pagure.io/389-ds-base/issue/49164
|
|
|
74ca47 |
|
|
|
74ca47 |
Author: wibrown
|
|
|
74ca47 |
|
|
|
74ca47 |
Review by: mreynolds (Thanks!)
|
|
|
74ca47 |
|
|
|
74ca47 |
(cherry picked from commit b1b0574d2cdb012ab206999ed51f08d3340386ce)
|
|
|
74ca47 |
---
|
|
|
74ca47 |
src/nunc-stans/ns/ns_thrpool.c | 8 ++++----
|
|
|
74ca47 |
1 file changed, 4 insertions(+), 4 deletions(-)
|
|
|
74ca47 |
|
|
|
74ca47 |
diff --git a/src/nunc-stans/ns/ns_thrpool.c b/src/nunc-stans/ns/ns_thrpool.c
|
|
|
74ca47 |
index 744749b..a867b39 100644
|
|
|
74ca47 |
--- a/src/nunc-stans/ns/ns_thrpool.c
|
|
|
74ca47 |
+++ b/src/nunc-stans/ns/ns_thrpool.c
|
|
|
74ca47 |
@@ -167,7 +167,7 @@ ns_thrpool_is_shutdown(struct ns_thrpool_t *tp)
|
|
|
74ca47 |
{
|
|
|
74ca47 |
/* We need to barrier this somehow? */
|
|
|
74ca47 |
int32_t result = 0;
|
|
|
74ca47 |
- __atomic_load(&(tp->shutdown), &result, __ATOMIC_SEQ_CST);
|
|
|
74ca47 |
+ __atomic_load(&(tp->shutdown), &result, __ATOMIC_ACQUIRE);
|
|
|
74ca47 |
return result;
|
|
|
74ca47 |
}
|
|
|
74ca47 |
|
|
|
74ca47 |
@@ -176,7 +176,7 @@ ns_thrpool_is_event_shutdown(struct ns_thrpool_t *tp)
|
|
|
74ca47 |
{
|
|
|
74ca47 |
/* We need to barrier this somehow? */
|
|
|
74ca47 |
int32_t result = 0;
|
|
|
74ca47 |
- __atomic_load(&(tp->shutdown_event_loop), &result, __ATOMIC_SEQ_CST);
|
|
|
74ca47 |
+ __atomic_load(&(tp->shutdown_event_loop), &result, __ATOMIC_ACQUIRE);
|
|
|
74ca47 |
return result;
|
|
|
74ca47 |
}
|
|
|
74ca47 |
|
|
|
74ca47 |
@@ -1402,7 +1402,7 @@ ns_thrpool_destroy(struct ns_thrpool_t *tp)
|
|
|
74ca47 |
#endif
|
|
|
74ca47 |
if (tp) {
|
|
|
74ca47 |
/* Set the flag to shutdown the event loop. */
|
|
|
74ca47 |
- __atomic_add_fetch(&(tp->shutdown_event_loop), 1, __ATOMIC_SEQ_CST);
|
|
|
74ca47 |
+ __atomic_add_fetch(&(tp->shutdown_event_loop), 1, __ATOMIC_RELEASE);
|
|
|
74ca47 |
|
|
|
74ca47 |
/* Finish the event queue wakeup job. This has the
|
|
|
74ca47 |
* side effect of waking up the event loop thread, which
|
|
|
74ca47 |
@@ -1491,7 +1491,7 @@ ns_thrpool_shutdown(struct ns_thrpool_t *tp)
|
|
|
74ca47 |
}
|
|
|
74ca47 |
/* Set the shutdown flag. This will cause the worker
|
|
|
74ca47 |
* threads to exit after they finish all remaining work. */
|
|
|
74ca47 |
- __atomic_add_fetch(&(tp->shutdown), 1, __ATOMIC_SEQ_CST);
|
|
|
74ca47 |
+ __atomic_add_fetch(&(tp->shutdown), 1, __ATOMIC_RELEASE);
|
|
|
74ca47 |
|
|
|
74ca47 |
/* Wake up the idle worker threads so they can exit. */
|
|
|
74ca47 |
pthread_mutex_lock(&(tp->work_q_lock));
|
|
|
74ca47 |
--
|
|
|
74ca47 |
2.9.3
|
|
|
74ca47 |
|