|
 |
dc8c34 |
From 77f1a1314a267c9f5b7a395344cfb3af57dcd3d6 Mon Sep 17 00:00:00 2001
|
|
|
dc8c34 |
From: Noriko Hosoi <nhosoi@redhat.com>
|
|
|
dc8c34 |
Date: Thu, 28 Mar 2013 15:30:13 -0700
|
|
|
dc8c34 |
Subject: [PATCH] Ticket 623 - cleanAllRUV task fails to cleanup config upon
|
|
|
dc8c34 |
completion
|
|
|
dc8c34 |
|
|
|
dc8c34 |
Bug description: coverity reported "13158 - Logically dead code'
|
|
|
dc8c34 |
|
|
|
dc8c34 |
Fix description: csn_as_string returns allocated csn string,
|
|
|
dc8c34 |
which needs to be reassigned to csnstr.
|
|
|
dc8c34 |
|
|
|
dc8c34 |
https://fedorahosted.org/389/ticket/623
|
|
|
dc8c34 |
|
|
|
dc8c34 |
Reviewed by Nathan (Thank you!!)
|
|
|
dc8c34 |
(cherry picked from commit d5fe6ba773ef2655845df5152901fd5bb6a9d4e9)
|
|
|
dc8c34 |
---
|
|
|
dc8c34 |
ldap/servers/plugins/replication/repl5_replica_config.c | 2 +-
|
|
|
dc8c34 |
1 file changed, 1 insertion(+), 1 deletion(-)
|
|
|
dc8c34 |
|
|
|
dc8c34 |
diff --git a/ldap/servers/plugins/replication/repl5_replica_config.c b/ldap/servers/plugins/replication/repl5_replica_config.c
|
|
|
dc8c34 |
index 8710c04..0e29c6f 100644
|
|
|
dc8c34 |
--- a/ldap/servers/plugins/replication/repl5_replica_config.c
|
|
|
dc8c34 |
+++ b/ldap/servers/plugins/replication/repl5_replica_config.c
|
|
|
dc8c34 |
@@ -2367,7 +2367,7 @@ delete_cleaned_rid_config(cleanruv_data *clean_data)
|
|
|
dc8c34 |
/*
|
|
|
dc8c34 |
* If there is no maxcsn, set the proper csnstr
|
|
|
dc8c34 |
*/
|
|
|
dc8c34 |
- csn_as_string(clean_data->maxcsn, PR_FALSE, csnstr);
|
|
|
dc8c34 |
+ csnstr = csn_as_string(clean_data->maxcsn, PR_FALSE, csnstr);
|
|
|
dc8c34 |
if(csnstr == NULL || csn_get_replicaid(clean_data->maxcsn) == 0){
|
|
|
dc8c34 |
csnstr = slapi_ch_strdup("00000000000000000000");
|
|
|
dc8c34 |
}
|
|
|
dc8c34 |
--
|
|
|
dc8c34 |
1.8.1.4
|
|
|
dc8c34 |
|