|
 |
058656 |
From 73c72aba0ab31f9d16cdfd8879e9da5f3fb985e0 Mon Sep 17 00:00:00 2001
|
|
|
058656 |
From: Mark Reynolds <mreynolds@redhat.com>
|
|
|
058656 |
Date: Tue, 17 Oct 2017 12:39:18 -0400
|
|
|
058656 |
Subject: [PATCH] Ticket 48006 - Missing warning for invalid replica backoff
|
|
|
058656 |
configuration
|
|
|
058656 |
|
|
|
058656 |
Description: Add warning if you try to set a min backoff time that is
|
|
|
058656 |
greater than the configured maximum, or the max time that
|
|
|
058656 |
is less than the minimum.
|
|
|
058656 |
|
|
|
058656 |
Also fixed compiler warning in ldbm_config.c
|
|
|
058656 |
|
|
|
058656 |
https://pagure.io/389-ds-base/issue/48006
|
|
|
058656 |
|
|
|
058656 |
Reviewed by: firstyear(Thanks!)
|
|
|
058656 |
|
|
|
058656 |
(cherry picked from commit e123acb6987c75f6d7282b32c4f279b976eb6f5e)
|
|
|
058656 |
---
|
|
|
058656 |
.../plugins/replication/repl5_replica_config.c | 24 ++++++++++++++++++++--
|
|
|
058656 |
ldap/servers/slapd/back-ldbm/ldbm_config.c | 2 +-
|
|
|
058656 |
2 files changed, 23 insertions(+), 3 deletions(-)
|
|
|
058656 |
|
|
|
058656 |
diff --git a/ldap/servers/plugins/replication/repl5_replica_config.c b/ldap/servers/plugins/replication/repl5_replica_config.c
|
|
|
058656 |
index f28044c19..22d766143 100644
|
|
|
058656 |
--- a/ldap/servers/plugins/replication/repl5_replica_config.c
|
|
|
058656 |
+++ b/ldap/servers/plugins/replication/repl5_replica_config.c
|
|
|
058656 |
@@ -465,7 +465,8 @@ replica_config_modify(Slapi_PBlock *pb,
|
|
|
058656 |
}
|
|
|
058656 |
} else if (strcasecmp(config_attr, type_replicaBackoffMin) == 0) {
|
|
|
058656 |
if (apply_mods) {
|
|
|
058656 |
- PRUint64 val = atoll(config_attr_value);
|
|
|
058656 |
+ uint64_t val = atoll(config_attr_value);
|
|
|
058656 |
+ uint64_t max;
|
|
|
058656 |
|
|
|
058656 |
if (val <= 0) {
|
|
|
058656 |
*returncode = LDAP_UNWILLING_TO_PERFORM;
|
|
|
058656 |
@@ -475,11 +476,21 @@ replica_config_modify(Slapi_PBlock *pb,
|
|
|
058656 |
slapi_log_err(SLAPI_LOG_ERR, repl_plugin_name, "replica_config_modify - %s\n", errortext);
|
|
|
058656 |
break;
|
|
|
058656 |
}
|
|
|
058656 |
+ max = replica_get_backoff_max(r);
|
|
|
058656 |
+ if (val > max){
|
|
|
058656 |
+ *returncode = LDAP_UNWILLING_TO_PERFORM;
|
|
|
058656 |
+ PR_snprintf(errortext, SLAPI_DSE_RETURNTEXT_SIZE,
|
|
|
058656 |
+ "Attribute %s value (%s) is invalid, must be a number less than the max backoff time (%d).\n",
|
|
|
058656 |
+ config_attr, config_attr_value, (int)max);
|
|
|
058656 |
+ slapi_log_err(SLAPI_LOG_ERR, repl_plugin_name, "replica_config_modify - %s\n", errortext);
|
|
|
058656 |
+ break;
|
|
|
058656 |
+ }
|
|
|
058656 |
replica_set_backoff_min(r, val);
|
|
|
058656 |
}
|
|
|
058656 |
} else if (strcasecmp(config_attr, type_replicaBackoffMax) == 0) {
|
|
|
058656 |
if (apply_mods) {
|
|
|
058656 |
- PRUint64 val = atoll(config_attr_value);
|
|
|
058656 |
+ uint64_t val = atoll(config_attr_value);
|
|
|
058656 |
+ uint64_t min;
|
|
|
058656 |
|
|
|
058656 |
if (val <= 0) {
|
|
|
058656 |
*returncode = LDAP_UNWILLING_TO_PERFORM;
|
|
|
058656 |
@@ -490,6 +501,15 @@ replica_config_modify(Slapi_PBlock *pb,
|
|
|
058656 |
errortext);
|
|
|
058656 |
break;
|
|
|
058656 |
}
|
|
|
058656 |
+ min = replica_get_backoff_min(r);
|
|
|
058656 |
+ if (val < min) {
|
|
|
058656 |
+ *returncode = LDAP_UNWILLING_TO_PERFORM;
|
|
|
058656 |
+ PR_snprintf(errortext, SLAPI_DSE_RETURNTEXT_SIZE,
|
|
|
058656 |
+ "Attribute %s value (%s) is invalid, must be a number more than the min backoff time (%d).\n",
|
|
|
058656 |
+ config_attr, config_attr_value, (int)min);
|
|
|
058656 |
+ slapi_log_err(SLAPI_LOG_ERR, repl_plugin_name, "replica_config_modify - %s\n", errortext);
|
|
|
058656 |
+ break;
|
|
|
058656 |
+ }
|
|
|
058656 |
replica_set_backoff_max(r, val);
|
|
|
058656 |
}
|
|
|
058656 |
} else if (strcasecmp(config_attr, type_replicaPrecisePurge) == 0) {
|
|
|
058656 |
diff --git a/ldap/servers/slapd/back-ldbm/ldbm_config.c b/ldap/servers/slapd/back-ldbm/ldbm_config.c
|
|
|
058656 |
index 2ef4652ce..feb993366 100644
|
|
|
058656 |
--- a/ldap/servers/slapd/back-ldbm/ldbm_config.c
|
|
|
058656 |
+++ b/ldap/servers/slapd/back-ldbm/ldbm_config.c
|
|
|
058656 |
@@ -388,7 +388,7 @@ ldbm_config_directory_set(void *arg, void *value, char *errorbuf, int phase, int
|
|
|
058656 |
goto done;
|
|
|
058656 |
}
|
|
|
058656 |
slapi_pblock_destroy(search_pb);
|
|
|
058656 |
- if (NULL == s || '\0' == s || 0 == PL_strcmp(s, "(null)")) {
|
|
|
058656 |
+ if (NULL == s || '\0' == *s || 0 == PL_strcmp(s, "(null)")) {
|
|
|
058656 |
slapi_log_err(SLAPI_LOG_ERR,
|
|
|
058656 |
"ldbm_config_directory_set", "db directory is not set; check %s in the db config: %s\n",
|
|
|
058656 |
CONFIG_DIRECTORY, CONFIG_LDBM_DN);
|
|
|
058656 |
--
|
|
|
058656 |
2.13.6
|
|
|
058656 |
|