#16 Add a missing space in the xen dracut config
Opened 2 years ago by mrc0mmand. Modified 2 years ago
centos/ mrc0mmand/kickstarts make-dracut-happy  into  master

file modified
+1 -1
@@ -148,7 +148,7 @@ 

  # enable resizing on copied AMIs

  echo 'install_items+=" sgdisk "' > /etc/dracut.conf.d/sgdisk.conf

  

- echo 'add_drivers+="xen-netfront xen-blkfront "' > /etc/dracut.conf.d/xen.conf

+ echo 'add_drivers+=" xen-netfront xen-blkfront "' > /etc/dracut.conf.d/xen.conf

  # Rerun dracut for the installed kernel (not the running kernel):

  KERNEL_VERSION=$(rpm -q kernel --qf '%{V}-%{R}.%{arch}\n')

  dracut -f /boot/initramfs-$KERNEL_VERSION.img $KERNEL_VERSION

file modified
+1 -1
@@ -148,7 +148,7 @@ 

  # enable resizing on copied AMIs

  echo 'install_items+=" sgdisk "' > /etc/dracut.conf.d/sgdisk.conf

  

- echo 'add_drivers+="xen-netfront xen-blkfront "' > /etc/dracut.conf.d/xen.conf

+ echo 'add_drivers+=" xen-netfront xen-blkfront "' > /etc/dracut.conf.d/xen.conf

  # Rerun dracut for the installed kernel (not the running kernel):

  KERNEL_VERSION=$(rpm -q kernel --qf '%{V}-%{R}.%{arch}\n')

  dracut -f /boot/initramfs-$KERNEL_VERSION.img $KERNEL_VERSION

otherwise dracut complains quite loudly:

 # dracut -f
 /etc/dracut.conf.d/xen.conf:add_drivers+="xen-netfront xen-blkfront "

 dracut: WARNING: <key>+=" <values> ": <values> should have surrounding white spaces!
 dracut: WARNING: This will lead to unwanted side effects! Please fix the configuration file.

/cc @arrfab

LGTM, let me tag @bstinson for final review and then merge so that it can be used for next 8-stream composes

Metadata Update from @arrfab:
- Request assigned

2 years ago