#40 Add MBS configuration
Merged 4 months ago by lrossett. Opened 4 months ago by merlinm.
centos/ merlinm/centpkg mbs  into  develop

file modified
+4

@@ -30,3 +30,7 @@ 

  [centpkg.distgit]

  apibaseurl = https://gitlab.com

  token = 

+ 

+ [centpkg.mbs]

+ auth_method = kerberos

+ api_url = https://mbs.stream.rdu2.redhat.com/module-build-service/1/

Adding module build service configuration for Stream.

The change looks ok, but do we need a python code change as well? I don't see any "centpkg.mbs" references in the code.

This change also needs to land in https://src.fedoraproject.org/rpms/centpkg.

The change looks ok, but do we need a python code change as well? I don't see any "centpkg.mbs" references in the code.

Thanks for reviewing!

No, there is no python code change needed. The section names in the config file are picked up from the basename of the invoking command (eg., centpkg). The mbs suffix is hard-coded. All this behavior is inherited from existing code in rpkg. See here for where rpkg is accessing these values.

This change also needs to land in https://src.fedoraproject.org/rpms/centpkg.

Yes it does. The next release of the Fedora package will automatically pick up this change after it has been merged and tagged here. I'll be happy to create a PR to bump the package once I see the merge/tag here.

Sounds good, merging it.

Pull-Request has been merged by lrossett

4 months ago

This has been released in version 0.6.5.

Metadata