Compare https://www.centos.org/sponsors and https://www.stg.centos.org/sponsors .. Probably something missing in the way to parse list ?
Metadata Update from @arrfab: - Issue tagged with: revamp
Previously, sponsors were manged using a post structure under _sponsors directory. Now, jekyll-theme-centos theme expects sponsors information in the _data/sponsors/carousel.yml file and images in the assets/img/sponsors/ directory. So, we need to migrate the sponsors _post structure to _data structure to make it work. The change tries to normalize the way we process iterative content in the theme.
post
_sponsors
_data/sponsors/carousel.yml
assets/img/sponsors/
See jekyll-theme-centos-sponsors project and its documentation.
Migration completed. Could you check please? It seems that in the specific case of cpanel sponsor we don't have an image file for it.
Changes: - https://git.centos.org/centos/centos.org/c/d63347fd9b0f2b532d0c56723e24ea264bd07640?branch=staging
Ah, didn't know there were multiple docs and jekyll-theme-centos-* .. Maybe worth consolidating somewhere and also include in this README.md file so that we have pointers to documentation (outside of just instructions about how to run podman container locally) ?
For cpanel, I guess you rebased from main branch somehow, as image and info were removed in this commit
main
I see the needed change for the images to be at specific size, reason why rendering is looking bad on https://www.stg.centos.org/sponsors/ now Wondering who'll have to fix the potential merge issues between main and staging branch when new revamp version will have to go live (and not lose all content/edit from main branch)
staging
Maybe worth consolidating somewhere and also include in this README.md file so that we have pointers to documentation (outside of just instructions about how to run podman container locally) ?
Agreed. I was considering to consolidate them in the jekyll-theme-centos project's readme file itself. Though, I am still working on it.
I see the needed change for the images to be at specific size, reason why rendering is looking bad on https://www.stg.centos.org/sponsors/ now
Yes. I can correct the images' size to be in the ratio the theme expects. It was necessary to find a compromise to achieve best presentation on different cases.
Wondering who'll have to fix the potential merge issues between main and staging branch when new revamp version will have to go live (and not lose all content/edit from main branch)
Maybe a collaborative effort along with docs-sig? @shaunm any thought on this?
docs-sig
In this respect, after having staging ready, it might be worth considering to freeze the main branch as soon as possible to reduce the number of conflicts we all need to solve during an eventual merge into staging. Otherwise it may become the never-ending story :)
I thought I merged main into revamp before merging revamp into staging. Looking at git log staging..origin/main right now, tho, it's clear there's content missing, and not just very new stuff. Maybe I didn't pull origin/main into my local checkout first. I'll do a merge this weekend and double-check the changes I see in the log right now. But as always, the more eyeballs looking for mistakes, the better.
revamp
git log staging..origin/main
origin/main
Updated sponsor image size using resize-sponsor-logo.sh (from site's root directory):
podman run --rm --name resize-sponsor-logo -v $PWD:/site:z registry.gitlab.com/centos/artwork/centos-web/pipelines/toolbox/gm:latest resize-sponsor-logo
It uses GraphicMagick to resize the image without loosing the original image ratio. See:
podman run --rm --name resize-sponsor-logo -v $PWD:/site:z registry.gitlab.com/centos/artwork/centos-web/pipelines/toolbox/gm:latest resize-sponsor-logo --help
If the result is not acceptable, please let me know to correct it. Thanks!
The sponsors page looks like it's rendering correctly now, but I don't see a way to navigate to it. In the current website, there's a link in the footer with a (random? rotating?) single sponsor banner. That's not in the footer from the new theme. I'd like to get thoughts from you two on where a sponsors link should be. In the footer? In the top navbar links? In the body of the index page?
IMHO, we should still have it on main page (as it was kind of "agreement" we had with sponsors before) and eventually a link in the navbar (so that even when navigating away from home page, there would be a way to still get access to through though menu)
Enabled sponsors sections in homepage's footer. Note that design may not be the best at the moment. Comments are welcome to improve how it looks.
I didn't realize it would be that easy to enable. The white background isn't great. Playing with a web inspector, it looks like dropping bg-light and text-body-emphasis lets it pick up the footer design.
bg-light
text-body-emphasis
Here's a crack at putting it in the navbar: https://git.centos.org/centos/centos.org/pull-request/234
Thanks for the feedback! Updated in jekyll-theme-centos container image v2.51.1-beta.70 with these changes. Note that, since you are using your own home layout, it is necessary to remove the bg-light there first to see the changes.
Some logos (e.g., aws') don't look good on dark background. Wondering if we need to establish a white background instead of transparent convention when presenting sponsors logos? White color is also the one used to present them in the sponsors page.
@areguera would you mind updating https://git.centos.org/centos/centos.org/blob/staging/f/container.specs#_1 to reflect needed changes ? The new workflow would automatically pull down needed container image/tag as it's parses that file
Updated sponsors cards presentation to use max-width and max-height instead of width alone. Previously, it was forcing a fixed width on all images. It was causing images smaller than 242px to be expanded and, consequently, seen in low quality.
@areguera . Thanks .. was wondering if we can just have a little bit more "space" between sponsors and logos as it seems really condensed (compact) . Just comparing actual https://www.stg.centos.org/sponsors/ layout and https://www.centos.org/sponsors/ (more readable to me). What do you think ?
Sure! Added in jekyll-theme-centos-sponsors v1.0.30-beta.12. I am checking issues to see what other changes need to be added before creating a new theme version.
Updated container.specs file to render the site using sponsors presentation latest updates. Including a fix for Use bg-white on sponsor cards.
@areguera looking good ! Let's close this issue as resolved now
Metadata Update from @arrfab: - Issue status updated to: Closed (was: Open)
Log in to comment on this ticket.